Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-300 refactor : 사용자 정보를 수정하는 api endpoints 통합 #78

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

saint6839
Copy link
Contributor

💁‍♂️ PR 내용

  • /api/v1/members/name

  • /api/v1/members/consents

  • /api/v1/members/resources

위 endpoint들을 하나의 endpoint로 통합하였습니다.

🙏 작업

[AS-IS]
이름, 알림여부 설정, resource 수정 api가 각각 하나씩 3개의 api로 분리되어 있었음

[TO-BE]
PATCH /api/v1/members/me 라는 하나의 api로 관리되어지도록 수정

🤖 테스트 체크리스트

  • 테스트코드 작성
  • api spec 수정

@saint6839 saint6839 requested review from gojung and junhaesung and removed request for gojung December 27, 2022 13:35
@saint6839 saint6839 self-assigned this Dec 27, 2022
@saint6839
Copy link
Contributor Author

클라분들 요청에 따라, 추후에 반영될 예정입니다.

Copy link
Member

@junhaesung junhaesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하위호환 유지하려면 v1 api 삭제하시면 안됩니다.
삭제하신 api 들 다시 살려주시고, deprecated 정도로만 표시해주세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants