Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chunk size for file upload in multipart request to 10MB per … #224

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Refactor chunk size for file upload in multipart request to 10MB per … #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions httpclient/multipartrequest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (c *Client) DoMultiPartRequest(method, endpoint string, files map[string][]
return nil, err
}

log.Debug("Executing multipart request", zap.String("method", method), zap.String("endpoint", endpoint))
log.Info("Executing multipart request", zap.String("method", method), zap.String("endpoint", endpoint))

// body, contentType, err := createMultipartRequestBody(files, formDataFields, fileContentTypes, formDataPartHeaders, log)
// if err != nil {
Expand Down Expand Up @@ -339,7 +339,7 @@ func setFormDataPartHeader(fieldname, filename, contentType string, customHeader
// - error: An error object indicating failure during the file upload. This could be due to issues such as file reading errors
// or writer errors.
func chunkFileUpload(file *os.File, writer io.Writer, log logger.Logger, updateProgress func(int64)) error {
const chunkSize = 5124 * 1024 // 5124 KB in bytes (5 MB)
const chunkSize = 10240 * 1024 // 5124 KB in bytes (5 MB)
buffer := make([]byte, chunkSize)
totalWritten := int64(0)
chunkWritten := int64(0)
Expand Down Expand Up @@ -404,8 +404,8 @@ func logUploadProgress(fileSize int64, log logger.Logger) func(int64) {

if percentage >= lastLoggedPercentage+logInterval {
log.Info("Upload progress",
zap.Int64("uploaded_bytes", uploaded),
zap.Int64("total_bytes", fileSize),
zap.Int64("uploaded_kbs", uploaded/1024),
zap.Int64("total_filesize_in_kb", fileSize/1024),
zap.String("percentage", fmt.Sprintf("%d%%", percentage)))
lastLoggedPercentage = percentage
}
Expand Down
Loading