Split targets and props nuget tests #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rande/PropsAndTargets
brbayes-msft
approved these changes
Feb 1, 2024
|
It seems like dependabot/dependabot-core#8945 fixed this problem, so probably not needed to break this out now. |
|
@jakecoffman seems your right. It might behoove us to do something similar in the future, but we can cross that bridge when we come to is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of the dependencies field is not reliable, so this was causing the files to show a diff (even though they're expressing the same thing) and cause flaky tests. By splitting these tests up we avoid the ordering problem without needing to change any larger architecture.