only report dependencies from project files that have a target framework #9347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smoke tests are failing for expected reasons, going to start on those now. The short version is that a dependency is now only reported for its initiating |
JoeRobich
approved these changes
Mar 21, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies-only-from-project
branch
from
bed7caf to
2b15320
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies-only-from-project
branch
from
2b15320 to
23e137d
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies-only-from-project
branch
from
23e137d to
60aaf65
Compare
|
Edit: My smoke-test changes were out-of-date. I've updated that branch so this shouldn't be an issue any more. Original comment: The failing smoke test is unrelated to this PR. Error message/diff looks like: --- smoke.yaml
+++ result.yaml
@@ -100,7 +97,7 @@
support_file: false
type: file
- content: |
- # This file is automatically @generated by Poetry 1.7.1 and should not be changed by hand.
+ # This file is automatically @generated by Poetry 1.8.2 and should not be changed by hand.
|
abdulapopoola
approved these changes
Mar 26, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies-only-from-project
branch
from
6953abf to
8a885f7
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies-only-from-project
branch
from
8a885f7 to
171d06c
Compare
abdulapopoola
deleted the
dev/brettfo/nuget-dependencies-only-from-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
<TargetFramework>cannot be parsed from a.csproj/.vbproj/.fsproj, there's no meaningful update that can be performed, so we explicitly check for that. This also means that we can't pull dependencies directly frompackages.config, etc. because we still depend on the project file's contents, so the tests were updated to reflect that.global.jsonanddotnet-tools.jsonare exceptions to requiring a project file and are still handled appropriately.Update to smoke-tests
This PR depends on a PR dependabot/smoke-tests#197 and they must be taken in parallel.
Temporary commit has been removed.
N.b., this PR has a temporary commit that points to the smoke-tests PR branch to show the smoke-tests passing. That commit will need to be removed before this is merged.