use content of discovery JSON to report dependency files #11026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-file-fetcher
branch
3 times, most recently
from
413213b to
680089e
Compare
|
Failing e2e NPM test is not related to this PR; there seems to be a missing file/404 during it's update test. |
sebasgomez238
approved these changes
Dec 2, 2024
randhircs
approved these changes
Dec 3, 2024
randhircs
force-pushed
the
dev/brettfo/nuget-file-fetcher
branch
from
680089e to
7b16a02
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-file-fetcher
branch
from
7b16a02 to
c74664d
Compare
kbukum1
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a temporary commit that redirects the smoke tests. This commit will need to be reverted before this PR can be merged.
Corresponding smoke tests PR: dependabot/smoke-tests#239
A large PR from last week (#10994) added all relevant files to the generated discovery JSON. This PR is a direct extension to that by removing all custom file parsing from Ruby and instead returning the files as reported via the discovery JSON.
The result is a large reduction in the size and complexity of the Ruby code.
One effect is the smoke tests needed to be updated because we're now sorting the dependency files before reporting them upstream. Another effect is that if a project contains no reportable dependencies, we don't report that
.csproj.