Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and use the correct node version when starting Next Build. #20132

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Dec 18, 2024

Description

This corrects an issue where the Next Build server would not start up correctly when a CMS Tugboat instance is stood up. The underlying issue was our not using the correct Node.js version for Next Build on Tugboat when we upgraded Next Build from v16 to v18. This corrects that and will ensure that Next Build on CMS Tugboat always uses the correct version.

Relates to #20507

Testing done

Visited the Next Build site on the CMS Tugboat instance connected to this PR: https://next-mtm8unctm8wvkyykpkapajohgwrnkju8.ci.cms.va.gov/pittsburgh-health-care/stories/

Screenshots

QA steps

  1. Go to the Tugboat dashboard for this PR: https://tugboat.vfs.va.gov/6763201c5134c90adaad18ce
  2. Rebuild the instance (Under 'Actions', under the title).
  3. Once the instance is rebuilt, visit https://next-mtm8unctm8wvkyykpkapajohgwrnkju8.ci.cms.va.gov/ . This should be a VA.gov 404 page; this is normal, as Next Build does not build the homepage.
  4. Visit https://next-mtm8unctm8wvkyykpkapajohgwrnkju8.ci.cms.va.gov/pittsburgh-health-care/stories/ . The page should load with data.

Note that there are missing images in the header and footer of these pages. This is a problem that will need to be corrected in Next-Build; #20520 is open to work on that.

@timcosgrove timcosgrove requested a review from a team as a code owner December 18, 2024 19:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 19:18 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 20:09 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 20:29 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 21:30 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 20, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 21, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 22, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 23, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 24, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 25, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 26, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 27, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 28, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 30, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 31, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 1, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2025 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 7, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 8, 2025 08:34 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 29, 2025 23:16 Destroyed
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 30, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 31, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 1, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2025 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 3, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 4, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 5, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 6, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 7, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 8, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 9, 2025 08:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 10, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 11, 2025 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 23:45 Destroyed
Copy link

Checking composer.lock changes...

Comment on lines +235 to +237
# Start the next build preview server
- bash -lc 'composer va:next:build'
- bash -lc 'composer va:next:start' &
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only substantive change here. Next.js must be built before the server can be started; that is changed here. Also, the & puts this task in the background; otherwise, it starts the server but then never continues because composer va:next:start holds the 'command line'.

Comment on lines -8 to +11
- cms
- web
- storybook
- next

- cms
- web
- storybook
- next
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly all changes in this file are spacing/autoformatting; the actual change is marked below.

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-aut

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Everything works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants