-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and use the correct node version when starting Next Build. #20132
base: main
Are you sure you want to change the base?
Conversation
Checking composer.lock changes... |
Checking composer.lock changes... |
Checking composer.lock changes... |
Checking composer.lock changes... |
GitHub Workflows (.github/workflows/*.yml)Have you...
|
Checking composer.lock changes... |
Checking composer.lock changes... |
# Start the next build preview server | ||
- bash -lc 'composer va:next:build' | ||
- bash -lc 'composer va:next:start' & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only substantive change here. Next.js must be built before the server can be started; that is changed here. Also, the &
puts this task in the background; otherwise, it starts the server but then never continues because composer va:next:start
holds the 'command line'.
- cms | ||
- web | ||
- storybook | ||
- next | ||
|
||
- cms | ||
- web | ||
- storybook | ||
- next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly all changes in this file are spacing/autoformatting; the actual change is marked below.
Tugboat has finished building the preview for this pull request! Links:
Dashboard: |
Cypress Accessibility Violations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Everything works as expected!
Description
This corrects an issue where the Next Build server would not start up correctly when a CMS Tugboat instance is stood up. The underlying issue was our not using the correct Node.js version for Next Build on Tugboat when we upgraded Next Build from v16 to v18. This corrects that and will ensure that Next Build on CMS Tugboat always uses the correct version.
Relates to #20507
Testing done
Visited the Next Build site on the CMS Tugboat instance connected to this PR: https://next-mtm8unctm8wvkyykpkapajohgwrnkju8.ci.cms.va.gov/pittsburgh-health-care/stories/
Screenshots
QA steps
Note that there are missing images in the header and footer of these pages. This is a problem that will need to be corrected in Next-Build; #20520 is open to work on that.