lint: treat bash as sh #4888
Open
lint: treat bash as sh #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vim version 9.1.0965 [1] in commit b9b762c21f (patch 9.1.0965: filetype:
sh filetype set when detecting the use of bash, 2024-12-27) broke out
bash as a standalone filetype (whose runtime support already redirects
through the shell runtime support).
As a consequence, ALE didn't lint filetype=bash well. Teach it to
consider bash an alias of sh (until and unless it is desirable to have
bash-specific linters, at which point we may need to duplicate some
linters like shellcheck or find another way to mark them enabled for
bash).
Something like
runtime! ale_linters/sh/*.vim
in `ale_linters/bash/redirect_to_sh.vim` doesn't work because the
linters are defined with ale#linter#Define('sh', …).
[1]: vim/vim@b9b762c
|
I believe the Vim patch has also landed in Neovim. |
Indeed it landed with: neovim/neovim#31749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim version 9.1.0965 1 in commit b9b762c21f (patch 9.1.0965: filetype: sh filetype set when detecting the use of bash, 2024-12-27) broke out bash as a standalone filetype (whose runtime support already redirects through the shell runtime support).
As a consequence, ALE didn't lint filetype=bash well. Teach it to consider bash an alias of sh (until and unless it is desirable to have bash-specific linters, at which point we may need to duplicate some linters like shellcheck or find another way to mark them enabled for bash).
Something like
in
ale_linters/bash/redirect_to_sh.vimdoesn't work because the linters are defined with ale#linter#Define('sh', …).