fix(biome): send correct language to lsp proxy #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
Since Biome understands `typescriptreact` and `javascriptreact` as languages, we can send the `filetype` to the LSP, rather than only sending `typescript` for both `ts` and `tsx` files, or `javascript` for `js` and `jsx` files. fixes: dense-analysis#4752
w0rp
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Biome understands
typescriptreactandjavascriptreactas languages, we can send thefiletypeto the LSP, rather than only sendingtypescriptfor bothtsandtsxfiles, orjavascriptforjsandjsxfiles.fixes: #4752
I moved the
ale_typescript_biome.vadertests to justale_biome.vadersince it covers multiple languages, and I added some tests for this case. I also fixed what seemed like an issue with the biome tests where if the linters run first then the fixers fail. Now it saves the variables and resets them before the tests.Linting and biome vader tests both pass locally for me