Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4712 revert chktex 4661 #4725

Merged
merged 2 commits into from
Feb 26, 2024
Merged

4712 revert chktex 4661 #4725

merged 2 commits into from
Feb 26, 2024

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Feb 22, 2024

Reverts #4661 that breaks reporting on ALE.

Closes #4712

@hsanson hsanson requested a review from w0rp February 22, 2024 02:27
@hsanson hsanson self-assigned this Feb 22, 2024
@Jorenar Jorenar mentioned this pull request Feb 24, 2024
Merged
@hsanson hsanson mentioned this pull request Feb 25, 2024
Closed
@hsanson hsanson merged commit 00dcf52 into dense-analysis:master Feb 26, 2024
7 checks passed
@Jorenar
Copy link
Contributor

Jorenar commented Feb 26, 2024 •
edited
Loading

Re-opens bug #723

hsanson pushed a commit that referenced this pull request Feb 26, 2024
@Jorenar
Fix chktex highlighting wrong column when using tabs instead of spaces (
9b8413a 
#4727)

* Fix '-s' to be '-S' when setting 'TabSize=1' for chktex

Fixes #4712
Closes #4725

* Check if chktex's -S option is available

* Check chktex version instead of trying -S option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp Awaiting requested review from w0rp

Assignees

@hsanson hsanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last update broke chktex linting for LaTeX it is needed to go back to reflog HEAD@{5} to have it back.
2 participants
@hsanson @Jorenar