Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E1085: Not a callable type: elm_ls#GetOptions #4707

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

samuelhelen
Copy link
Contributor

  • Make elm linting not display an error all the time
  • Additionally change the name GetOptions to GetInitializationOptions for consistency with other files.

My motivation for these changes as an end user:
Error detected while processing BufWinEnter Autocommands for "*"..function
ale#events#LintOnEnter[5]..ale#Queue[33]..59_Lint[37]..ale#engine
#RunLinters[4]..64_GetLintFileValues[27]..2[1]..64_RunLinters[18]..
64_RunLinter[2]..ale#lsp_linter#CheckWithLSP[1]..ale#ls
p_linter#StartLSP[28]..66_StartIfExecutable[15]..66_StartWithCommand[13]..
66_StartLSP[6]..ale#lsp_linter#GetOptions:
line 9:
E1085: Not a callable type: elm_ls#GetOptions

I searched quickly through the issues and pull requests with "elm" and didn't find the same.

Rename GetOptions to GetInitializationOptions for consistency.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my limited testing. Thanks.

@hsanson hsanson merged commit 143074a into dense-analysis:master Jan 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants