Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add biome (ex. rome) support for javascript #4701

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add biome (ex. rome) support for javascript #4701

merged 1 commit into from
Jan 14, 2024

Conversation

akiomik
Copy link
Contributor

@akiomik akiomik commented Dec 30, 2023

This PR adds biome as fixers.

ref: #4674 #3280

@akiomik akiomik force-pushed the biome-support branch 10 times, most recently from 5ab1599 to 209993e Compare December 30, 2023 19:23
@akiomik akiomik marked this pull request as ready for review December 30, 2023 19:28
hsanson
hsanson previously approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but tests are not passing. Make sure supported-tools.md and doc/ale-supported-languages-and-tools.txt have listed the new tool in same order.

@akiomik akiomik force-pushed the biome-support branch 2 times, most recently from 085cbf1 to c914c2d Compare January 14, 2024 11:50
@akiomik
Copy link
Contributor Author

akiomik commented Jan 14, 2024

Thank you for review, I've fixed it.

@akiomik
Copy link
Contributor Author

akiomik commented Jan 14, 2024

I was mistaking Java for Javascript 😂
I've resolved conflicts.

hsanson
hsanson approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and quick response.

@hsanson hsanson merged commit 8922478 into dense-analysis:master Jan 14, 2024
7 checks passed
@akiomik akiomik deleted the biome-support branch January 14, 2024 14:07
toxeus added a commit to toxeus/ale that referenced this pull request Jan 14, 2024
@toxeus
Revert "Add biome support for javascript (dense-analysis#4701)"
db64d7c 
This reverts commit 8922478.
hsanson pushed a commit that referenced this pull request Feb 24, 2024
@toxeus
Add full support for biome (#4705)
9cc8383 
* Revert "Add biome support for javascript (#4701)"

This reverts commit 8922478.

* Add support for biome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akiomik @hsanson