Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not error for specifier with version requirement and @ symbol in path #40

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 9, 2024

suggested: format!("{req}{version}/{new_sub_path}"),
}),
));
if req.version_req.version_text() == "*" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is this condition.

@dsherret dsherret merged commit d8d67b3 into denoland:main Dec 9, 2024
1 check passed
@dsherret dsherret deleted the fix_do_not_error_specifier_version_requirement_at_symbol_path branch December 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants