Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): support ranges separated by && or comma #38

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix(npm): support ranges separated by && or comma #38

merged 3 commits into from
Oct 21, 2024

Conversation

dsherret
Copy link
Member

Improves loose parsing to allow && in npm dependencies.

bartlomieju
bartlomieju reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cover react@>=16, <=18 case too?

@dsherret dsherret changed the title fix(npm): support && fix(npm): support ranges separated by && or comma Oct 21, 2024
@dsherret dsherret merged commit 1c376cd into denoland:main Oct 21, 2024
1 check passed
@dsherret dsherret deleted the fix_logical_and branch October 21, 2024 18:42
@dsherret dsherret mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @lucacasonato @bartlomieju