Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move NpmPackageId from deno_npm #14

Closed
wants to merge 1 commit into from

Conversation

dsherret
Copy link
Member

Going to move this down here even though I liked it in deno_npm because I need this for deno_lockfile, but deno_npm depends on deno_lockfile. I could create deno_npm_types, but that seems like an unnecessary maintenance burden.

https://github.com/denoland/deno_npm/blob/f409ede427a6f38a35204cbedfa928487d0c835b/src/lib.rs#L29-L32

@dsherret
Copy link
Member Author

I just realized this is not necessary. That said, I want to integrate some of these changes back into deno_npm so I'll leave this as draft until that's done.

@dsherret dsherret closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant