feat: node references #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
commented
Dec 5, 2024
src/parser.rs
Outdated
Comment on lines
197
to
204
| .elements | ||
| .iter() | ||
| .map(|node| Rc::unwrap_or_clone(node.clone())) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| self.resolve_reference_for_nodes(specifier, &mut nodes)?; | ||
|
|
||
| namespace_def.elements = nodes.into_iter().map(Rc::new).collect(); |
There was a problem hiding this comment.
wish this could be cleaned up/avoided
dsherret
reviewed
Dec 11, 2024
| .iter() | ||
| .flat_map(|node| { | ||
| if let Some(namespace) = node.namespace_def() { | ||
| walk_rc_nodes(&namespace.elements) |
There was a problem hiding this comment.
Is it possible for someone to create a circular reference by being stupid and cause an inifinte loop here?
crowlKats
force-pushed
the
node-references
branch
from
ced2e39 to
6465aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.