Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display non-exported types referenced in exported types #361

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: display non-exported types referenced in exported types #361

merged 2 commits into from
Oct 26, 2023

Conversation

dsherret
Copy link
Member

Closes #277

dsherret
dsherret commented Oct 26, 2023
View reviewed changes
js/test.ts
@@ -13,7 +13,7 @@ Deno.test({
const entries = await doc(
"https://deno.land/[email protected]/fmt/colors.ts",
);
assertEquals(entries.length, 48);
assertEquals(entries.length, 49);
Copy link
Member Author

@dsherret dsherret Oct 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rgb type is used in a parameter, but not exported: https://deno.land/[email protected]/fmt/colors.ts?source=

bartlomieju
bartlomieju approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool, this is useful. I wonder if we have any problems like that in lib.deno.ns.d.ts

@dsherret dsherret merged commit f505ffa into denoland:main Oct 26, 2023
3 checks passed
@dsherret dsherret deleted the feat_display_referenced_non_exported_type_symbols branch October 26, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display referenced non-exported type symbols
2 participants
@dsherret @bartlomieju