fix(test): share fail fast tracker between threads (#20515)

denoland · Sep 15, 2023 · 11f0ccf · 11f0ccf
1 parent d226970
commit 11f0ccf
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/cli/tests/integration/test_tests.rs b/cli/tests/integration/test_tests.rs
@@ -182,7 +182,7 @@ itest!(quiet {
 });
 
 itest!(fail_fast {
-  args: "test --fail-fast test/fail_fast.ts",
+  args: "test --fail-fast test/fail_fast.ts test/fail_fast_other.ts",
   exit_code: 1,
   output: "test/fail_fast.out",
 });

diff --git a/cli/tests/testdata/test/fail_fast.out b/cli/tests/testdata/test/fail_fast.out
@@ -1,4 +1,5 @@
 Check [WILDCARD]/test/fail_fast.ts
+Check [WILDCARD]/test/fail_fast_other.ts
 running 10 tests from ./test/fail_fast.ts
 test 1 ... FAILED ([WILDCARD])
 

diff --git a/cli/tests/testdata/test/fail_fast_other.ts b/cli/tests/testdata/test/fail_fast_other.ts
@@ -0,0 +1,3 @@
+Deno.test("test 11", () => {
+  throw new Error();
+});
diff --git a/cli/tools/test/mod.rs b/cli/tools/test/mod.rs
@@ -828,12 +828,13 @@ async fn test_specifiers(
   });
   HAS_TEST_RUN_SIGINT_HANDLER.store(true, Ordering::Relaxed);
   let mut reporter = get_test_reporter(&options);
+  let fail_fast_tracker = FailFastTracker::new(options.fail_fast);
 
   let join_handles = specifiers.into_iter().map(move |specifier| {
     let worker_factory = worker_factory.clone();
     let permissions = permissions.clone();
     let sender = sender.clone();
-    let fail_fast_tracker = FailFastTracker::new(options.fail_fast);
+    let fail_fast_tracker = fail_fast_tracker.clone();
     let specifier_options = options.specifier.clone();
     spawn_blocking(move || {
       create_and_run_current_thread(test_specifier(