Skip to content

Commit

Permalink
do NOT tick the reformat code before commit checkbox in webstorm
Browse files Browse the repository at this point in the history
  • Loading branch information
denniskaselow committed May 26, 2020
1 parent a3238a4 commit 2b160ce
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 16 deletions.
15 changes: 7 additions & 8 deletions lib/system_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ class SystemGenerator extends GeneratorForAnnotation<Generate> {
}

if (needsInitializations(components, systems, managers)) {
result..writeln(' @override')..writeln(' void initialize() {')..writeln(
' super.initialize();');
result
..writeln(' @override')
..writeln(' void initialize() {')
..writeln(' super.initialize();');
if (components.isNotEmpty) {
result.writeln(mapperInitializations);
}
Expand Down Expand Up @@ -142,21 +144,18 @@ class SystemGenerator extends GeneratorForAnnotation<Generate> {
}

bool needsDeclarations(Set components, Iterable<String> systems,
Iterable<String> managers) =>
Iterable<String> managers) =>
components.isNotEmpty || systems.isNotEmpty || managers.isNotEmpty;

bool needsInitializations(Set components, Iterable<String> systems,
Iterable<String> managers) =>
Iterable<String> managers) =>
components.isNotEmpty || systems.isNotEmpty || managers.isNotEmpty;

Iterable<String> _getValues(DartObject objectValue, String fieldName) =>
objectValue.getField(fieldName).toListValue().map(_nameOfDartObject);

String _nameOfDartObject(DartObject dartObject) =>
dartObject
.toTypeValue()
.element
.name;
dartObject.toTypeValue().element.name;

String _toMapperName(String typeName) => '${_toVariableName(typeName)}Mapper';

Expand Down
16 changes: 8 additions & 8 deletions test/system_generator_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,21 @@ void main() {

test('should create constructor and mappers for allOf aspect', () async {
final result =
await generate(systemWithAllOfAspect, generator, buildStep);
await generate(systemWithAllOfAspect, generator, buildStep);

expect(result, equals(systemWithAllOfAspectResult));
});

test('should create constructor and mappers for oneOf aspect', () async {
final result =
await generate(systemWithOneOfAspect, generator, buildStep);
await generate(systemWithOneOfAspect, generator, buildStep);

expect(result, equals(systemWithOneOfAspectResult));
});

test('should create constructor and excluded aspects', () async {
final result =
await generate(systemWithExcludeAspect, generator, buildStep);
await generate(systemWithExcludeAspect, generator, buildStep);

expect(result, equals(systemWithExcludeAspectResult));
});
Expand All @@ -83,12 +83,12 @@ void main() {

test(
'''should create constructor with aspect parameter if user wants to pass aspects''',
() async {
final result = await generate(
systemWithConstructorAcceptingAspects, generator, buildStep);
() async {
final result = await generate(
systemWithConstructorAcceptingAspects, generator, buildStep);

expect(result, equals(systemWithConstructorAcceptingAspectsResult));
});
expect(result, equals(systemWithConstructorAcceptingAspectsResult));
});

test('should do everything together', () async {
final result = await generate(systemWithEverything, generator, buildStep);
Expand Down

0 comments on commit 2b160ce

Please sign in to comment.