Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for new ethnicity attributes #82

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Add documentation for new ethnicity attributes #82

merged 4 commits into from
Sep 26, 2024

Conversation

yoshih
Copy link

@yoshih yoshih commented May 6, 2024 •
edited
Loading

References https://github.com/denkungsart/filmmakers/issues/10211

  • add ethnic_background, ethnic_background_details and ethnic_background_custom to response fields table
  • add new attributes to JSON example
  • add deprecation note about ethnic_appearances
  • add changelog entry

@yoshih yoshih force-pushed the filmmakers-10211-ethnicity branch from 229fe4f to b3906d9 Compare May 6, 2024 13:14
@yoshih yoshih requested a review from andreas-venturini May 6, 2024 17:39
andreas-venturini
andreas-venturini reviewed May 15, 2024
View reviewed changes
Copy link
Member

@andreas-venturini andreas-venturini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mark ethnic_appearances as deprecated and advise to use the new fields instead

@yoshih yoshih marked this pull request as ready for review May 15, 2024 19:22
@yoshih yoshih force-pushed the filmmakers-10211-ethnicity branch 2 times, most recently from 2f6bb55 to 7008b54 Compare May 15, 2024 19:28
@yoshih yoshih requested a review from andreas-venturini May 15, 2024 19:34
andreas-venturini
andreas-venturini reviewed May 21, 2024
View reviewed changes
Copy link
Member

@andreas-venturini andreas-venturini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to improve the wording a bit, but I'll do that myself

@andreas-venturini andreas-venturini changed the title Add explanation for new ethnicity fields Add documentation for new ethnicity attributes May 21, 2024
yoshih added 3 commits August 15, 2024 19:06
@yoshih
Add explanation for new ethnicity fields
b5543aa 
Include in JSON example

Add changelog entry
@yoshih
Add deprecation note for ethnic_appearances
cc71b03
@yoshih
Remove explanation about visibility for casters
0e68390 
We treat those fields like other publicly visible fields now
@yoshih yoshih force-pushed the filmmakers-10211-ethnicity branch from 7962b4d to 0e68390 Compare August 15, 2024 17:06
@andreas-venturini andreas-venturini merged commit 33a434b into main Sep 26, 2024
10 checks passed
@andreas-venturini andreas-venturini deleted the filmmakers-10211-ethnicity branch September 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-venturini andreas-venturini andreas-venturini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshih @andreas-venturini