Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoaram get-jobs command #38512

Merged
merged 15 commits into from
Feb 13, 2025
Merged

Panoaram get-jobs command #38512

merged 15 commits into from
Feb 13, 2025

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented Feb 6, 2025

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-44394

Description

Adding a fix for get-jobs command, since the given ID exists just in one device and we didn't handle it the code.
It was failing on ID not found since it was searching it in all devices instead of the correct one (and only one).
Actually try-except block was added.

Must have

  • Tests
  • Documentation

@rshunim rshunim requested a review from jbabazadeh February 6, 2025 04:14
@rshunim rshunim self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PAN-OS/Integrations/Panorama
   Panorama.py6138223563%34, 341, 348, 371, 378, 380, 408, 413, 415, 430, 436, 439, 447, 451–452, 456, 458, 461–462, 464, 468–469, 476, 484, 490, 493–494, 498, 549–551, 570, 605, 620, 667, 673, 691, 696, 724–725, 733–734, 791–792, 795, 823–824, 859, 869, 875, 881–882, 884–886, 888, 890–891, 894–895, 897–900, 902, 928–929, 952, 957, 962, 969, 976, 981, 988, 995, 1001, 1014–1015, 1019, 1024–1025, 1027–1028, 1030, 1048–1050, 1058, 1065, 1071–1073, 1075, 1077–1078, 1080, 1087–1089, 1098, 1100–1101, 1103–1104, 1106, 1113, 1220–1221, 1249, 1264, 1266–1267, 1269–1272, 1275–1276, 1278–1280, 1283–1285, 1287–1288, 1290, 1313, 1349, 1382, 1410, 1452, 1455, 1481, 1504, 1533, 1544, 1562, 1571, 1578, 1585–1586, 1589, 1601, 1614–1616, 1618, 1620, 1636, 1642, 1644, 1648, 1650, 1656, 1665, 1672–1673, 1675, 1681, 1688–1689, 1691, 1708, 1716, 1719, 1724, 1747, 1749, 1761, 1763, 1780, 1792, 1839, 1841–1853, 1855, 1904, 1911, 1917, 1924, 1926–1929, 1931, 1947–1951, 1955–1959, 1962, 1964, 1966–1967, 1969, 1971, 1973, 1978, 1985–1986, 1988, 1994, 2001–2002, 2004, 2024, 2026, 2030, 2061, 2063, 2065, 2082, 2092, 2098, 2103, 2113, 2119, 2126–2139, 2141–2142, 2144, 2146, 2150–2159, 2161, 2175, 2183, 2189, 2197–2200, 2202, 2232–2235, 2243, 2251, 2259–2260, 2284–2286, 2291, 2294–2296, 2301, 2316–2320, 2325, 2343–2344, 2346–2354, 2356–2361, 2363–2364, 2366–2369, 2371, 2373, 2378, 2385–2386, 2388, 2394, 2401–2402, 2404, 2423, 2427, 2433–2434, 2436, 2442, 2449, 2455, 2461, 2469–2470, 2472, 2489, 2502, 2508, 2515–2520, 2522, 2524, 2529–2536, 2538, 2552, 2559, 2565, 2573–2576, 2578, 2594–2595, 2597–2599, 2603–2605, 2608, 2610, 2612, 2617, 2624–2625, 2627, 2633, 2640–2641, 2643, 2662, 2666, 2673, 2679, 2685, 2693–2694, 2696, 2710, 2719, 2725, 2732–2734, 2736, 2738, 2742–2745, 2747, 2761, 2768, 2774, 2782–2785, 2787, 2810–2814, 2845, 2848, 2852–2855, 2857, 2859–2860, 2868, 2892, 2895, 2899–2901, 2903, 2912, 2918, 2924, 2932–2933, 2935, 2958, 2967–2968, 2970–2971, 2973, 2980, 2986–2994, 2996–2997, 3004–3008, 3010, 3013, 3028, 3035, 3041, 3049–3052, 3054, 3074–3076, 3114–3115, 3149–3150, 3158, 3203, 3212, 3223–3224, 3226–3228, 3230, 3252, 3254, 3256, 3285–3286, 3358, 3360, 3377–3381, 3383–3388, 3390–3399, 3401–3403, 3407–3409, 3413–3415, 3419–3421, 3425–3427, 3432–3435, 3437–3438, 3443, 3449, 3455, 3463, 3465, 3467, 3512, 3515, 3520, 3527–3532, 3534, 3537–3542, 3546–3551, 3553, 3581, 3589–3590, 3613–3616, 3618–3620, 3622–3625, 3629–3631, 3633–3635, 3637–3640, 3671, 3679, 3685, 3693, 3695–3697, 3699, 3794, 3830–3831, 3846–3848, 3850, 3852, 3854, 3858–3860, 3862–3864, 3866, 3868, 3881, 3907–3911, 3913, 3926–3927, 3933–3935, 3937, 3939–3943, 3954–3974, 3976–3980, 3982, 3992–3993, 3995, 4001–4004, 4006–4010, 4012, 4037–4038, 4044–4045, 4053, 4056–4060, 4069, 4071, 4081, 4154–4156, 4167, 4171, 4181, 4197, 4201–4202, 4204, 4206, 4242, 4247–4249, 4251, 4253, 4255, 4261, 4275–4285, 4287–4291, 4293, 4298–4305, 4307–4309, 4312–4314, 4317–4318, 4320–4322, 4325–4327, 4330–4331, 4333–4334, 4337–4338, 4340–4341, 4344–4345, 4347, 4375, 4377, 4381, 4383, 4385, 4390, 4453, 4457, 4466, 4468, 4470, 4474, 4479–4480, 4482, 4484, 4486, 4488–4489, 4493, 4505, 4509–4510, 4525, 4558, 4562–4563, 4565–4566, 4568, 4572, 4583, 4585, 4589, 4643, 4647, 4705, 4719, 4725, 4731, 4738–4739, 4741, 4758, 4765, 4768, 4774, 4781–4786, 4788, 4790, 4797–4802, 4804, 4820–4821, 4832–4834, 4837–4839, 4848–4852, 4881, 4889, 4895, 4902–4905, 4907, 4920, 4925–4927, 4930–4931, 4934, 4936–4939, 4941, 4947, 4954–4955, 4957–4960, 4962, 4964, 4981, 5029, 5052–5054, 5056, 5062–5063, 5065, 5071, 5078–5079, 5081, 5083, 5097–5100, 5102, 5104, 5110–5111, 5113, 5119, 5126–5130, 5132, 5134, 5137, 5139–5140, 5142, 5144, 5149, 5163–5165, 5167, 5173–5174, 5176, 5182, 5189–5193, 5195, 5197, 5215–5217, 5219–5221, 5240, 5246–5247, 5249–5254, 5260, 5267–5275, 5277–5278, 5281, 5284–5287, 5289, 5291–5293, 5298, 5327, 5329–5332, 5334, 5336, 5341, 5343–5345, 5347, 5365, 5367, 5369, 5371, 5373, 5377, 5379, 5381, 5383, 5385, 5389, 5391, 5393, 5395, 5397, 5399, 5406, 5408–5411, 5413, 5415, 5420, 5422, 5424–5425, 5435–5436, 5438, 5440–5442, 5444–5446, 5485, 5487–5489, 5491–5495, 5497–5499, 5501–5503, 5505–5507, 5509–5512, 5514–5517, 5519–5521, 5523–5525, 5528, 5531–5533, 5549, 5551, 5554, 5557, 5610, 5622–5623, 5625, 5627, 5668–5669, 5673, 5678, 5718–5720, 5722–5725, 5727, 5729, 5734, 5736–5738, 5740, 5771, 5777, 5779, 5781, 5785, 5795, 5799, 5807, 5813, 5817, 5819, 5823, 5825, 5827, 5833, 5851–5857, 5859, 5861–5864, 5866, 5868, 5873, 5875, 5877–5878, 5888–5889, 5892, 5894–5896, 5898–5900, 5903, 5925, 5927, 5933, 5937, 5941, 5953, 5957, 5963, 5972, 5976, 5980, 5985, 5991–5992, 5994–5997, 5999, 6006–6019, 6055, 6061, 6065, 6069–6076, 6078, 6080, 6084, 6088–6096, 6098–6101, 6103, 6105–6106, 6113–6118, 6120, 6122, 6136, 6139, 6146, 6150, 6152, 6155–6156, 6158–6164, 6166, 6169, 6175–6176, 6178–6181, 6183, 6188–6189, 6195–6196, 6203–6207, 6209–6211, 6213–6216, 6218, 6230, 6237–6238, 6245–6253, 6255, 6271, 6280–6283, 6285–6286, 6293–6301, 6303, 6305, 6307–6309, 6311–6312, 6318–6323, 6325, 6358, 6364, 6369, 6373–6374, 6381–6383, 6385–6386, 6388, 6402, 6409–6410, 6417–6422, 6426, 6457, 6459, 6465–6467, 6469, 6481, 6486–6487, 6489, 6495, 6502–6504, 6506, 6508, 6510, 6514–6515, 6518, 6528, 6533, 6538–6539, 6541, 6547, 6554–6558, 6560, 6563–6571, 6573–6574, 6576–6577, 6580, 6592, 6597–6599, 6605, 6612, 6614, 6616, 6620–6621, 6623, 6633, 6638, 6643–6645, 6650, 6657–6659, 6661, 6665–6673, 6675–6676, 6678–6679, 6681, 6719, 6725–6727, 6732, 6739–6741, 6743, 6745, 6748–6749, 6751, 6761, 6766, 6771–6773, 6778, 6785–6788, 6791–6799, 6801–6802, 6804, 6806, 6808, 6820, 6826–6827, 6829, 6834, 6841–6845, 6847, 6849, 6852–6853, 6855, 6865, 6870, 6875–6877, 6882, 6889–6891, 6893, 6896–6898, 6901–6902, 6904–6905, 6907–6908, 6910, 6921, 6926–6928, 6933, 6938, 6943, 6949, 6956, 6958–6959, 6961–6963, 6970, 6975, 6988, 6993, 6995, 7002–7006, 7008–7010, 7021–7022, 7041, 7044–7059, 7061, 7073–7075, 7097, 7103, 7108–7109, 7125–7127, 7136–7142, 7147–7149, 7154, 7156, 7159–7165, 7170–7172, 7177–7178, 7181–7187, 7192–7194, 7199–7200, 7203–7209, 7214–7216, 7221–7222, 7225–7230, 7235–7236, 7241–7242, 7245–7251, 7256–7258, 7263–7264, 7331, 7336, 7347, 7353, 7355, 7359–7362, 7364, 7366–7374, 7390, 7406, 7409, 7427, 7431–7465, 7477, 7480–7481, 7488, 7495, 7497, 7501–7503, 7505–7506, 7508–7511, 7515, 7517, 7521–7523, 7526, 7571, 7581–7582, 7592, 7599, 7601, 7605–7606, 7608–7609, 7611–7612, 7615, 7629, 7636, 7638, 7642–7645, 7647–7648, 7651, 7665, 7672, 7674, 7678–7683, 7687, 7701, 7708, 7710, 7721, 7724–7729, 7731, 7742–7747, 7749, 7753–7755, 7757–7758, 7762–7763, 7776, 7778–7780, 7783, 7802–7803, 7807–7808, 7813, 7819, 7821, 7826, 7833, 7835, 7839–7841, 7843–7845, 7850–7851, 7854, 7856–7859, 7861, 7863, 7878, 7893, 7895, 7900, 7909, 7911, 7915–7916, 7918, 7925, 7935, 7937, 7941–7942, 7946, 7986, 7992–7995, 8010, 8025, 8027, 8031–8032, 8037, 8054, 8056, 8060–8061, 8066, 8107, 8109, 8113–8114, 8119, 8180, 8182, 8186–8187, 8192, 8209, 8211, 8215–8216, 8221, 8229, 8231, 8235–8236, 8240–8242, 8250–8251, 8259, 8277, 8279, 8285, 8287–8288, 8299, 8317, 8325–8329, 8332, 8336, 8342, 8348, 8354–8356, 8369, 8373, 8375–8377, 8391, 8400, 8408–8410, 8412, 8415–8417, 8421, 8425–8427, 8430, 8434, 8440, 8446–8447, 8450, 8491–8493, 8496, 8507, 8514, 8519, 8537, 8540, 8546–8547, 8557–8558, 8568–8569, 8578–8587, 8591, 8597–8598, 8607–8608, 8616, 8622, 8627, 8631–8634, 8636, 8638, 8642–8643, 8645, 8655, 8689–8690, 8692–8693, 8696, 8698–8703, 8705, 8714–8715, 8728–8729, 8844, 8866, 8883, 8947, 8970–8971, 8979–8980, 9005, 9017, 9031–9033, 9048, 9053–9055, 9084, 9095–9096, 9100, 9114–9115, 9121, 9161–9165, 9171, 9178–9181, 9184–9186, 9188, 9198, 9204–9206, 9208–9209, 9211, 9219, 9221, 9223, 9225, 9263, 9274–9275, 9406, 9735, 9982, 10164, 10292, 10302, 10347, 10445, 10452–10454, 10458, 10465–10467, 10488, 10495–10497, 10533, 10536–10537, 10639, 10646–10648, 10678–10680, 10682, 10685–10686, 10693, 10710–10713, 10719–10720, 10727, 10745–10748, 10754–10755, 10762, 10973–10975, 10977–10980, 10982, 10984–10985, 10987–10988, 10992–10993, 11003, 11094–11097, 11102, 11142, 11192, 11308, 11310–11312, 11331, 11346–11348, 11354, 11435–11436, 11438, 11450, 11462, 11474, 11488, 11500, 11512, 11526, 11540, 11554, 11569, 11591, 11593, 11618, 11638, 11649, 11659, 11670, 11687, 11705, 11727, 11745, 11761, 11781, 11803, 11818, 11828, 11864, 11878, 11897, 11916, 11952, 11972–11973, 11975, 11977, 11988–11993, 11995, 12019, 12031–12032, 12034–12035, 12042–12044, 12048–12049, 12051–12052, 12056, 12089, 12118, 12186, 12215, 12228, 12248–12251, 12255, 12263–12268, 12274–12279, 12314, 12324, 12327, 12361–12368, 12371, 12373–12375, 12396, 12401–12404, 12414, 12418, 12422, 12449, 12460, 12495, 12548, 12711–12714, 12792, 12831, 12935, 12995, 13006, 13100, 13102, 13124–13127, 13131, 13181, 13253, 13277, 13313, 13359, 13729, 13756–13757, 13799, 13868, 13880, 13977–13980, 13982, 14012, 14014–14016, 14018–14019, 14073–14074, 14076–14078, 14085–14087, 14093, 14118–14120, 14122, 14128–14129, 14131–14132, 14134–14135, 14137, 14139, 14185, 14207–14209, 14211, 14232, 14262, 14277, 14281, 14343, 14348, 14374–14375, 14386–14388, 14392, 14474, 14488, 14490, 14565–14566, 14620, 14669, 14671–14673, 14719–14720, 14723–14724, 14726–14730, 14732, 14734–14737, 15017, 15077, 15079–15081, 15083–15088, 15090–15091, 15095
TOTAL6138223563% 

Tests Skipped Failures Errors Time
323 0 💤 0 ❌ 0 🔥 7.284s ⏱️

@rshunim rshunim added ForceMerge Forcing the merge of the PR despite the build status and removed ForceMerge Forcing the merge of the PR despite the build status labels Feb 10, 2025
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@rshunim rshunim added the ForceMerge Forcing the merge of the PR despite the build status label Feb 11, 2025
@rshunim
Copy link
Contributor Author

rshunim commented Feb 11, 2025

@yuvalbenshalom @jbabazadeh
ForceMerge is needed here due to 4 TPBs which fail in the nightly too
(same errors here)

@yuvalbenshalom yuvalbenshalom merged commit afdfa27 into master Feb 13, 2025
15 of 17 checks passed
@yuvalbenshalom yuvalbenshalom deleted the Panorama-fix-get-jobs branch February 13, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants