JSONFeedApiModule - Handle a case where No Indicators were Retrieved

[ShacharKidor]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

fixes: XSUP-46217.

Description

1. Fixed the following error (described In this issue - XSUP-46217) - by better handling the case where the feed retrieved no indicators (in the JSONFeedApiModule).

Error: [Traceback (most recent call last):
   
   File ""<string>"", line 573, in <module>
   File ""<string>"", line 569, in main
   File ""<string>"", line 499, in feed_main
   File ""<string>"", line 7872, in return_error
 Exception: Error in MalwareBazaar Feed integration ['NoneType' object is not iterable] 

2. Implemented a retry mechanism for the fetch-indicators command in the MalwareBazaarFeed integration, that catches known server-side and communication errors from MalwareBazaare and starts a retry after 10 seconds.

Must have

• Tests
• Documentation

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/AccentureCTI_Feed/Integrations/ACTIIndicatorFeed
ACTIIndicatorFeed.py	49	10	79%	104, 110, 112–116, 118, 122, 128
Packs/ApiModules/Scripts/JSONFeedApiModule
JSONFeedApiModule.py	212	31	85%	73–75, 111, 170–171, 261–264, 307, 316–317, 319, 335, 339, 341, 351, 358, 365, 368, 411–413, 421–422, 425, 428, 431–433
Packs/FeedGCPWhitelist/Integrations/FeedGoogleIPRanges
FeedGoogleIPRanges.py	8	0	100%
Packs/FeedMalwareBazaar/Integrations/MalwareBazaarFeed
MalwareBazaarFeed.py	35	7	80%	16, 25, 33, 78–81
TOTAL	304	48	84%

Tests	Skipped	Failures	Errors	Time
29	0 💤	0 ❌	0 🔥	8.248s ⏱️

[content-bot]

This PR was automatically updated by a GitHub Action

• ApiModules pack version was bumped to 2.2.41.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

[ShacharKidor]

@yuvalbenshalom - As you can see here the retry mechanism is working as expected:

Also, the original Exception: Error in MalwareBazaar Feed integration ['NoneType' object is not iterable]
doesn't appear in our logs since I uploaded the change of the JsonFeedApiModule.

[ShacharKidor]

@yuvalbenshalom - Please force merge the PR, validation are failing due to:
[RN106] - This ticket -CIAC-12789,
[ST111] - Missing sections headers (not mandatory).