Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration - Add support for Absolute API V3 #38427

Merged
merged 33 commits into from
Feb 13, 2025

Conversation

MLainer1
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Add support for Absolute API V3

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jan 30, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Absolute/Integrations/Absolute
   Absolute.py49811177%185, 238, 241, 260, 262, 300–301, 303, 305–306, 308, 310–311, 367, 381, 449–451, 453–454, 456, 464, 518–523, 525–527, 533–536, 540–541, 921–943, 952–953, 955, 977, 984–985, 987–988, 990–991, 993–995, 997, 999–1003, 1009, 1015–1016, 1018–1021, 1023–1025, 1027, 1029–1031, 1034–1035, 1041, 1048–1049, 1052–1056, 1058, 1060–1064, 1070, 1086
TOTAL49811177% 

Tests Skipped Failures Errors Time
50 0 💤 0 ❌ 0 🔥 2.353s ⏱️

@MLainer1 MLainer1 marked this pull request as ready for review February 3, 2025 13:18
@MLainer1 MLainer1 requested a review from Shellyber February 3, 2025 13:18
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work.

  • I know you're working on more tests so I haven't reviewed that yet.
  • Don't forget to update the README as well with all the changes
  • Please add Breaking changes release notes with all the changes and also refer them to the readme for more information

Packs/Absolute/Integrations/Absolute/Absolute.yml Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/Absolute.yml Outdated Show resolved Hide resolved
Packs/Absolute/ReleaseNotes/2_0_0.md Outdated Show resolved Hide resolved
Packs/Absolute/ReleaseNotes/2_0_0.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/Absolute.py Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/Absolute.py Outdated Show resolved Hide resolved
@MLainer1 MLainer1 requested a review from Shellyber February 6, 2025 09:46
@MLainer1 MLainer1 requested a review from sapirshuker as a code owner February 6, 2025 12:10
@Shellyber Shellyber removed the request for review from sapirshuker February 6, 2025 13:56
Packs/Absolute/Integrations/Absolute/Absolute.yml Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/Absolute.yml Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/Absolute.yml Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Packs/Absolute/ReleaseNotes/2_0_0.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@Shellyber Doc review completed.

Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And just go over the get_specific_page to see if relevant

Packs/Absolute/Integrations/Absolute/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
Please don't forget to add the label for force and a comment

@MLainer1 MLainer1 added the ForceMerge Forcing the merge of the PR despite the build status label Feb 13, 2025
@MLainer1
Copy link
Contributor Author

This PR needs a force merge due to planned breaking changes:
image
All the breaking changes are listed in the integration description

@JudahSchwartz JudahSchwartz merged commit 4e4108c into master Feb 13, 2025
14 of 16 checks passed
@JudahSchwartz JudahSchwartz deleted the enhancement_absolute_v3 branch February 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants