-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAN-OS Panorama integration implement show jobs id
#35929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PAN-OS Panorama integration implement `show jobs id` Refactor Panorama integration `show_jobs()` method to fetch job by id with the `show jobs id` command instead of filtering through `show jobs all`. * Apply suggestions from code review Co-authored-by: Jacob Levy <[email protected]> * Update release notes for PAN-OS pack * Update Packs/PAN-OS/ReleaseNotes/2_1_34.md Co-authored-by: Jacob Levy <[email protected]> --------- Co-authored-by: Jacob Levy <[email protected]> Co-authored-by: israelpoli <[email protected]>
israelpoli
approved these changes
Aug 18, 2024
maimorag
pushed a commit
that referenced
this pull request
Aug 27, 2024
* PAN-OS Panorama integration implement `show jobs id` (#35761) * PAN-OS Panorama integration implement `show jobs id` Refactor Panorama integration `show_jobs()` method to fetch job by id with the `show jobs id` command instead of filtering through `show jobs all`. * Apply suggestions from code review Co-authored-by: Jacob Levy <[email protected]> * Update release notes for PAN-OS pack * Update Packs/PAN-OS/ReleaseNotes/2_1_34.md Co-authored-by: Jacob Levy <[email protected]> --------- Co-authored-by: Jacob Levy <[email protected]> Co-authored-by: israelpoli <[email protected]> * autopep --------- Co-authored-by: Alp Eren Kose <[email protected]> Co-authored-by: Jacob Levy <[email protected]> Co-authored-by: israelpoli <[email protected]> Co-authored-by: ipolishuk <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Sep 10, 2024
* PAN-OS Panorama integration implement `show jobs id` (demisto#35761) * PAN-OS Panorama integration implement `show jobs id` Refactor Panorama integration `show_jobs()` method to fetch job by id with the `show jobs id` command instead of filtering through `show jobs all`. * Apply suggestions from code review Co-authored-by: Jacob Levy <[email protected]> * Update release notes for PAN-OS pack * Update Packs/PAN-OS/ReleaseNotes/2_1_34.md Co-authored-by: Jacob Levy <[email protected]> --------- Co-authored-by: Jacob Levy <[email protected]> Co-authored-by: israelpoli <[email protected]> * autopep --------- Co-authored-by: Alp Eren Kose <[email protected]> Co-authored-by: Jacob Levy <[email protected]> Co-authored-by: israelpoli <[email protected]> Co-authored-by: ipolishuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
docs-approved
Internal PR
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@alperenkose
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Solves an issue in XSOAR Upgrade Assurance Integration
Description
PAN-OS 10.2 and onwards returns multiple values for a job id for the
show jobs all
call and this creates an issue on GenericPolling running forever and waiting for the timeout. See issue on PaloAltoNetworks/xsoar-panos-upgrade-automation#14 .This PR implements refactoring of
show_jobs()
method in PAN-OS Pack / Panorama integration to runshow jobs id
command when a job id is provided instead of filtering on theshow jobs all
output. Since a single job is returned with the command this resolves the above mentioned issue.Must have