Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN-OS Panorama integration implement show jobs id #35929

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@alperenkose

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Solves an issue in XSOAR Upgrade Assurance Integration

Description

PAN-OS 10.2 and onwards returns multiple values for a job id for the show jobs all call and this creates an issue on GenericPolling running forever and waiting for the timeout. See issue on PaloAltoNetworks/xsoar-panos-upgrade-automation#14 .

This PR implements refactoring of show_jobs() method in PAN-OS Pack / Panorama integration to run show jobs id command when a job id is provided instead of filtering on the show jobs all output. Since a single job is returned with the command this resolves the above mentioned issue.

Must have

  • Tests
  • Documentation

* PAN-OS Panorama integration implement `show jobs id`

Refactor Panorama integration `show_jobs()` method to fetch job by
id with the `show jobs id` command instead of filtering through
`show jobs all`.

* Apply suggestions from code review

Co-authored-by: Jacob Levy <[email protected]>

* Update release notes for PAN-OS pack

* Update Packs/PAN-OS/ReleaseNotes/2_1_34.md

Co-authored-by: Jacob Levy <[email protected]>

---------

Co-authored-by: Jacob Levy <[email protected]>
Co-authored-by: israelpoli <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Aug 18, 2024
@content-bot content-bot requested a review from israelpoli August 18, 2024 13:20
Copy link

github-actions bot commented Aug 18, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PAN-OS/Integrations/Panorama
   Panorama.py5920220162%14, 306, 313, 336, 343, 345, 373, 378, 380, 395, 401, 404, 412, 416–417, 421, 423, 426–427, 429, 433–434, 441, 449, 455, 458–459, 463, 480, 514–516, 535, 570, 585, 632, 638, 656, 661, 689–690, 698–699, 756–757, 760, 788–789, 824, 834, 840, 846–847, 849–851, 853, 855–856, 859–860, 862–865, 867, 893–894, 917, 922, 927, 934, 941, 946, 953, 960, 966, 979–980, 984, 989–990, 992–993, 995, 1013–1015, 1023, 1030, 1036–1038, 1040, 1042–1043, 1045, 1052–1054, 1063, 1065–1066, 1068–1069, 1071, 1078, 1185–1186, 1214, 1229, 1231–1232, 1234–1237, 1240–1241, 1243–1245, 1248–1250, 1252–1253, 1255, 1278, 1314, 1347, 1375, 1417, 1420, 1446, 1469, 1498, 1509, 1527, 1536, 1543, 1550–1551, 1554, 1566, 1579–1581, 1583, 1585, 1601, 1607, 1609, 1613, 1615, 1621, 1630, 1637–1638, 1640, 1646, 1653–1654, 1656, 1673, 1681, 1684, 1689, 1712, 1714, 1726, 1728, 1745, 1757, 1804, 1806–1818, 1820, 1869, 1876, 1882, 1889, 1891–1894, 1896, 1912–1916, 1920–1924, 1927, 1929, 1931–1932, 1934, 1936, 1938, 1943, 1950–1951, 1953, 1959, 1966–1967, 1969, 1989, 1991, 1995, 2026, 2028, 2030, 2047, 2057, 2063, 2068, 2078, 2084, 2091–2104, 2106–2107, 2109, 2111, 2115–2124, 2126, 2140, 2148, 2154, 2162–2165, 2167, 2191–2194, 2198, 2206, 2214–2215, 2234–2236, 2241, 2244–2246, 2251, 2266–2270, 2275, 2293–2294, 2296–2304, 2306–2311, 2313–2314, 2316–2319, 2321, 2323, 2328, 2335–2336, 2338, 2344, 2351–2352, 2354, 2373, 2377, 2383–2384, 2386, 2392, 2399, 2405, 2411, 2419–2420, 2422, 2439, 2452, 2458, 2465–2470, 2472, 2474, 2479–2486, 2488, 2502, 2509, 2515, 2523–2526, 2528, 2544–2545, 2547–2549, 2553–2555, 2558, 2560, 2562, 2567, 2574–2575, 2577, 2583, 2590–2591, 2593, 2612, 2616, 2623, 2629, 2635, 2643–2644, 2646, 2660, 2669, 2675, 2682–2684, 2686, 2688, 2692–2695, 2697, 2711, 2718, 2724, 2732–2735, 2737, 2760–2764, 2795, 2798, 2802–2805, 2807, 2809–2810, 2818, 2842, 2845, 2849–2851, 2853, 2862, 2868, 2874, 2882–2883, 2885, 2908, 2917–2918, 2920–2921, 2923, 2930, 2936–2944, 2946–2947, 2954–2958, 2960, 2963, 2978, 2985, 2991, 2999–3002, 3004, 3024–3026, 3064–3065, 3099–3100, 3108, 3153, 3162, 3173–3174, 3176–3178, 3180, 3202, 3204, 3206, 3235–3236, 3308, 3310, 3327–3331, 3333–3338, 3340–3349, 3351–3353, 3357–3359, 3363–3365, 3369–3371, 3375–3377, 3382–3385, 3387–3388, 3393, 3399, 3405, 3413, 3415, 3417, 3462, 3465, 3470, 3477–3482, 3484, 3487–3492, 3496–3501, 3503, 3531, 3539–3540, 3563–3566, 3568–3570, 3572–3575, 3579–3581, 3583–3585, 3587–3590, 3621, 3629, 3635, 3643, 3645–3647, 3649, 3744, 3780–3781, 3796–3798, 3800, 3802, 3804, 3808–3810, 3812–3814, 3816, 3818, 3831, 3857–3861, 3863, 3876–3877, 3883–3885, 3887, 3889–3893, 3904–3924, 3926–3930, 3932, 3942–3943, 3945, 3951–3954, 3956–3960, 3962, 3987–3988, 3994–3995, 4003, 4006–4010, 4019, 4021, 4031, 4104–4106, 4117, 4121, 4131, 4147, 4151–4152, 4154, 4156, 4192, 4197–4199, 4201, 4203, 4205, 4211, 4225–4235, 4237–4241, 4243, 4248–4255, 4257–4259, 4262–4264, 4267–4268, 4270–4272, 4275–4277, 4280–4281, 4283–4284, 4287–4288, 4290–4291, 4294–4295, 4297, 4325, 4327, 4331, 4333, 4335, 4340, 4403, 4407, 4416, 4418, 4420, 4424, 4429–4430, 4432, 4434, 4436, 4438–4439, 4443, 4455, 4459–4460, 4475, 4508, 4512–4513, 4515–4516, 4518, 4522, 4533, 4535, 4539, 4593, 4597, 4655, 4669, 4675, 4681, 4688–4689, 4691, 4708, 4715, 4718, 4724, 4731–4736, 4738, 4740, 4747–4752, 4754, 4770–4771, 4782–4784, 4787–4789, 4798–4802, 4831, 4839, 4845, 4852–4855, 4857, 4870, 4875–4877, 4880–4881, 4884, 4886–4889, 4891, 4897, 4904–4905, 4907–4910, 4912, 4914, 4931, 4979, 5002–5004, 5006, 5012–5013, 5015, 5021, 5028–5029, 5031, 5033, 5047–5050, 5052, 5054, 5060–5061, 5063, 5069, 5076–5080, 5082, 5084, 5087, 5089–5090, 5092, 5094, 5099, 5113–5115, 5117, 5123–5124, 5126, 5132, 5139–5143, 5145, 5147, 5165–5167, 5169–5171, 5190, 5196–5197, 5199–5204, 5210, 5217–5225, 5227–5228, 5231, 5234–5237, 5239, 5241–5243, 5248, 5277, 5279–5282, 5284, 5286, 5291, 5293–5295, 5297, 5315, 5317, 5319, 5321, 5323, 5327, 5329, 5331, 5333, 5335, 5339, 5341, 5343, 5345, 5347, 5349, 5356, 5358–5361, 5363, 5365, 5370, 5372, 5374–5375, 5385–5386, 5388, 5390–5392, 5394–5396, 5435, 5437–5439, 5441–5445, 5447–5449, 5451–5453, 5455–5457, 5459–5462, 5464–5467, 5469–5471, 5473–5475, 5478, 5481–5483, 5499, 5501, 5504, 5507, 5560, 5572–5573, 5575, 5577, 5618–5619, 5623, 5628, 5668–5670, 5672–5675, 5677, 5679, 5684, 5686–5688, 5690, 5721, 5727, 5729, 5731, 5735, 5745, 5749, 5757, 5763, 5767, 5769, 5773, 5775, 5777, 5783, 5801–5807, 5809, 5811–5814, 5816, 5818, 5823, 5825, 5827–5828, 5838–5839, 5842, 5844–5846, 5848–5850, 5853, 5875, 5877, 5883, 5887, 5891, 5903, 5907, 5913, 5922, 5926, 5930, 5935, 5941–5942, 5944–5947, 5949, 5956–5969, 6005, 6011, 6015, 6019–6026, 6028, 6030, 6034, 6038–6046, 6048–6051, 6053, 6055–6056, 6063–6068, 6070, 6072, 6086, 6089, 6096, 6100, 6102, 6105–6106, 6108–6114, 6116, 6119, 6125–6126, 6128–6131, 6133, 6138–6139, 6145–6146, 6153–6157, 6159–6161, 6163–6166, 6168, 6180, 6187–6188, 6195–6203, 6205, 6221, 6230–6233, 6235–6236, 6243–6251, 6253, 6255, 6257–6259, 6261–6262, 6268–6273, 6275, 6309, 6315, 6320, 6324–6325, 6332–6334, 6336–6337, 6339, 6353, 6360–6361, 6368–6373, 6377, 6408, 6410, 6416–6418, 6420, 6432, 6437–6438, 6440, 6446, 6453–6455, 6457, 6459, 6461, 6465–6466, 6469, 6479, 6484, 6489–6490, 6492, 6498, 6505–6509, 6511, 6514–6522, 6524–6525, 6527–6528, 6531, 6543, 6548–6550, 6556, 6563, 6565, 6567, 6571–6572, 6574, 6584, 6589, 6594–6596, 6601, 6608–6610, 6612, 6616–6624, 6626–6627, 6629–6630, 6632, 6670, 6676–6678, 6683, 6690–6692, 6694, 6696, 6699–6700, 6702, 6712, 6717, 6722–6724, 6729, 6736–6739, 6742–6750, 6752–6753, 6755, 6757, 6759, 6771, 6777–6778, 6780, 6785, 6792–6796, 6798, 6800, 6803–6804, 6806, 6816, 6821, 6826–6828, 6833, 6840–6842, 6844, 6847–6849, 6852–6853, 6855–6856, 6858–6859, 6861, 6872, 6877–6879, 6884, 6889, 6894, 6900, 6907, 6909–6910, 6912–6914, 6921, 6926, 6939, 6944, 6946, 6953–6957, 6959–6961, 6972–6973, 6992, 6995–7010, 7012, 7024–7026, 7048, 7054, 7059–7060, 7076–7078, 7087–7093, 7098–7100, 7105, 7107, 7110–7116, 7121–7123, 7128–7129, 7132–7138, 7143–7145, 7150–7151, 7154–7160, 7165–7167, 7172–7173, 7176–7181, 7186–7187, 7192–7193, 7196–7202, 7207–7209, 7214–7215, 7282, 7287, 7298, 7304, 7306, 7310–7313, 7315, 7317–7325, 7341, 7357, 7360, 7378, 7382–7416, 7428, 7431–7432, 7439, 7446, 7448, 7452–7454, 7456–7457, 7459–7462, 7466, 7468, 7472–7474, 7477, 7522, 7532–7533, 7543, 7550, 7552, 7556–7557, 7559–7560, 7562–7563, 7566, 7580, 7587, 7589, 7593–7596, 7598–7599, 7602, 7616, 7623, 7625, 7629–7634, 7638, 7652, 7659, 7661, 7672, 7675–7680, 7682, 7693–7698, 7700, 7704–7706, 7708–7709, 7713–7714, 7727, 7729–7731, 7734, 7753–7754, 7758–7759, 7764, 7770, 7772, 7777, 7784, 7786, 7790–7792, 7794–7796, 7801–7802, 7805, 7807–7810, 7812, 7814, 7829, 7844, 7846, 7851, 7860, 7862, 7866–7867, 7869, 7876, 7886, 7888, 7892–7893, 7897, 7937, 7943–7946, 7961, 7976, 7978, 7982–7983, 7988, 8005, 8007, 8011–8012, 8017, 8058, 8060, 8064–8065, 8070, 8131, 8133, 8137–8138, 8143, 8160, 8162, 8166–8167, 8172, 8180, 8182, 8186–8187, 8191–8193, 8201–8202, 8210, 8228, 8230, 8236, 8238–8239, 8250, 8268, 8276–8280, 8283, 8287, 8293, 8299, 8305–8307, 8320, 8324, 8326–8328, 8342, 8351, 8359–8361, 8363, 8366–8368, 8372, 8376–8378, 8381, 8385, 8391, 8397–8398, 8401, 8442–8444, 8447, 8458, 8465, 8470, 8488, 8491, 8497–8498, 8508–8509, 8519–8520, 8529–8538, 8542, 8548–8549, 8558–8559, 8567, 8573, 8578, 8582–8585, 8587, 8589, 8593–8594, 8596, 8606, 8640–8641, 8643–8644, 8647, 8649–8654, 8656, 8665–8666, 8679–8680, 8795, 8817, 8834, 8898, 8921–8922, 8930–8931, 8956, 8968, 8982–8984, 8999, 9004–9006, 9035, 9046–9047, 9051, 9065–9066, 9072, 9112–9116, 9122, 9129–9132, 9135–9137, 9139, 9149, 9155–9157, 9159–9160, 9162, 9170, 9172, 9174, 9176, 9214, 9225–9226, 9357, 9686, 9945, 9948, 10123, 10251, 10261, 10306, 10404, 10411–10413, 10417, 10424–10426, 10447, 10454–10456, 10492, 10495–10496, 10598, 10605–10607, 10637–10639, 10641, 10644–10645, 10652, 10669–10672, 10678–10679, 10686, 10704–10707, 10713–10714, 10721, 10932–10934, 10936–10939, 10941, 10943–10944, 10946–10947, 10951–10952, 10962, 11053–11056, 11061, 11101, 11143, 11261, 11263–11265, 11284, 11299–11301, 11307, 11388–11389, 11391, 11403, 11415, 11427, 11441, 11453, 11465, 11479, 11493, 11507, 11522, 11544, 11546, 11571, 11591, 11602, 11612, 11623, 11640, 11658, 11680, 11698, 11714, 11734, 11756, 11771, 11781, 11817, 11831, 11850, 11869, 11905, 11925–11926, 11928, 11930, 11941–11946, 11948, 11972, 11984–11985, 11987–11988, 11995–11997, 12001–12002, 12004–12005, 12009, 12042, 12071, 12139, 12168, 12181, 12201–12204, 12208, 12216–12221, 12227–12232, 12267, 12277, 12280, 12314–12321, 12324, 12326–12328, 12349, 12354–12357, 12367, 12371, 12375, 12402, 12413, 12448, 12501, 12664–12667, 12745, 12784, 12888, 12948, 12959, 13053, 13055, 13077–13080, 13084, 13134, 13206, 13230, 13266, 13312, 13682, 13709–13710, 13752, 13821, 13833, 13930–13933, 13935, 13965, 13967–13969, 13971–13972, 14026–14027, 14029–14031, 14038–14040, 14046, 14073, 14075–14077, 14122–14123, 14126–14127, 14129–14133, 14135, 14137–14140, 14466, 14468–14470, 14472–14477, 14479–14480, 14484
TOTAL5920220162% 

Tests Skipped Failures Errors Time
1216 0 💤 0 ❌ 0 🔥 25.351s ⏱️

@israelpoli israelpoli merged commit 3546245 into master Aug 18, 2024
16 checks passed
@israelpoli israelpoli deleted the contrib/alperenkose_pan-os-show-jobs-id branch August 18, 2024 21:50
maimorag pushed a commit that referenced this pull request Aug 27, 2024
* PAN-OS Panorama integration implement `show jobs id` (#35761)

* PAN-OS Panorama integration implement `show jobs id`

Refactor Panorama integration `show_jobs()` method to fetch job by
id with the `show jobs id` command instead of filtering through
`show jobs all`.

* Apply suggestions from code review

Co-authored-by: Jacob Levy <[email protected]>

* Update release notes for PAN-OS pack

* Update Packs/PAN-OS/ReleaseNotes/2_1_34.md

Co-authored-by: Jacob Levy <[email protected]>

---------

Co-authored-by: Jacob Levy <[email protected]>
Co-authored-by: israelpoli <[email protected]>

* autopep

---------

Co-authored-by: Alp Eren Kose <[email protected]>
Co-authored-by: Jacob Levy <[email protected]>
Co-authored-by: israelpoli <[email protected]>
Co-authored-by: ipolishuk <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* PAN-OS Panorama integration implement `show jobs id` (demisto#35761)

* PAN-OS Panorama integration implement `show jobs id`

Refactor Panorama integration `show_jobs()` method to fetch job by
id with the `show jobs id` command instead of filtering through
`show jobs all`.

* Apply suggestions from code review

Co-authored-by: Jacob Levy <[email protected]>

* Update release notes for PAN-OS pack

* Update Packs/PAN-OS/ReleaseNotes/2_1_34.md

Co-authored-by: Jacob Levy <[email protected]>

---------

Co-authored-by: Jacob Levy <[email protected]>
Co-authored-by: israelpoli <[email protected]>

* autopep

---------

Co-authored-by: Alp Eren Kose <[email protected]>
Co-authored-by: Jacob Levy <[email protected]>
Co-authored-by: israelpoli <[email protected]>
Co-authored-by: ipolishuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants