Skip to content

Commit

Permalink
XSUP-45903: SplunkPy (#38375)
Browse files Browse the repository at this point in the history
* remove /

* use the connection_args

* use get_connection_args in update_remote_system

* rn

* updated the location of the base_url
  • Loading branch information
RotemAmit authored Feb 9, 2025
1 parent 1344d42 commit 40d9582
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 3 additions & 2 deletions Packs/SplunkPy/Integrations/SplunkPy/SplunkPy.py
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,8 @@ def update_remote_system_command(args, params, service: client.Service, auth_tok
delta = parsed_args.delta
notable_id = parsed_args.remote_incident_id
entries = parsed_args.entries
base_url = f"https://{params['host'].replace('https://', '')}:{params['port']}/"
connection_args = get_connection_args(params)
base_url = f"https://{connection_args['host']}:{connection_args['port']}/"
demisto.debug(f"mirroring args: entries:{parsed_args.entries} delta:{parsed_args.delta}")
if parsed_args.incident_changed and delta:
demisto.debug(
Expand Down Expand Up @@ -3352,7 +3353,6 @@ def main(): # pragma: no cover

connection_args = get_connection_args(params)

base_url = f"https://{params['host'].replace('https://', '')}:{params['port']}/"
auth_token = None
username = params['authentication']['identifier']
password = params['authentication']['password']
Expand Down Expand Up @@ -3404,6 +3404,7 @@ def main(): # pragma: no cover
elif command == 'splunk-submit-event':
splunk_submit_event_command(service, args)
elif command == 'splunk-notable-event-edit':
base_url = f"https://{connection_args['host']}:{connection_args['port']}/"
token = get_auth_session_key(service)
splunk_edit_notable_event_command(base_url, token, auth_token, args)
elif command == 'splunk-submit-event-hec':
Expand Down
5 changes: 5 additions & 0 deletions Packs/SplunkPy/ReleaseNotes/3_2_1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations

##### SplunkPy
Fixed an issue where the parsing of the parameter Server URL wasn't aligned in the integration.
2 changes: 1 addition & 1 deletion Packs/SplunkPy/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Splunk",
"description": "Run queries on Splunk servers.",
"support": "xsoar",
"currentVersion": "3.2.0",
"currentVersion": "3.2.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down

0 comments on commit 40d9582

Please sign in to comment.