[Pack][RecordedFuture][v1.8.3] Fix bug related to 'Trust any certific…

…ate (not secure)' setting. (#38508) (#38551)

* [Pack][RecordedFuture][v1.8.3] Fix bug related to 'Trust any certificate (not secure)' setting.

* [Pack][RecordedFuture][v1.8.3] Update docker image for Playbook Alerts integration.

* [Pack][RecordedFuture][v1.8.3] Add sections to settings.

---------

Co-authored-by: Dmytro B <[email protected]>
Co-authored-by: Maya Goldman <[email protected]>

Packs/RecordedFuture/Integrations/RecordedFuturePlaybookAlerts/RecordedFuturePlaybookAlerts.py

@@ -218,7 +218,7 @@ def _transform_incidents_attachments(incidents: list) -> None:
 def get_client(proxies: dict) -> Client:
     demisto_params = demisto.params()
     base_url = demisto_params.get("server_url", "").rstrip("/")
-    verify_ssl = not demisto_params.get("unsecure", False)
+    verify_ssl = not demisto_params.get("insecure", False)
 
     api_token = demisto_params.get("token", {}).get("password")
 

Packs/RecordedFuture/Integrations/RecordedFuturePlaybookAlerts/RecordedFuturePlaybookAlerts.yml

@@ -1,3 +1,6 @@
+sectionOrder:
+- Connect
+- Collect
 commonfields:
   id: RecordedFuturePlaybookAlerts
   version: -1
@@ -14,30 +17,44 @@ configuration:
   defaultvalue: https://api.recordedfuture.com/gw/xsoar/
   type: 0
   required: true
+  section: Connect
 - displaypassword: API Token
   name: token
   defaultvalue: ""
   type: 9
   hiddenusername: true
   required: true
+  section: Connect
 - display: Trust any certificate (not secure)
   name: insecure
   type: 8
   required: false
+  section: Connect
+  advanced: true
 - display: Use system proxy settings
   name: proxy
   type: 8
   required: false
+  section: Connect
+  advanced: true
 - display: Fetch incidents
   name: isFetch
   type: 8
   required: false
+  section: Collect
+- display: Incidents Fetch Interval
+  defaultvalue: '1'
+  name: incidentFetchInterval
+  type: 19
+  required: false
+  section: Collect
 - display: 'First Incidient Fetch: Time Range'
   additionalinfo: 'Limit incidents to include in the first fetch by time range. Input format: "NN hours" or "NN days". E.g., input "5 days" to fetch all incidents created in the last 5 days.'
   defaultvalue: 24 hours
   name: first_fetch
   type: 0
   required: false
+  section: Collect
 - display: 'Playbook Alerts: Fetched Categories'
   name: pa_categories
   additionalinfo: 'Some listed Playbook alert Categories might be unavailable due to limitations in the current Recorded Future subscription'
@@ -49,11 +66,13 @@ configuration:
   - Vulnerability
   - Code Repo Leakage
   required: false
+  section: Collect
 - display: Maximum number of incidents per fetch
   name: max_fetch
   defaultvalue: "50"
   type: 0
   required: false
+  section: Collect
 - display: 'Playbook Alerts: Fetched Statuses'
   name: pa_statuses
   type: 16
@@ -64,6 +83,7 @@ configuration:
   - Dismissed
   - Resolved
   required: false
+  section: Collect
 - display: 'Playbook Alerts: Fetched Priorities Threshold'
   name: pa_priorities
   type: 15
@@ -74,16 +94,18 @@ configuration:
   - Moderate
   - Informational
   required: false
+  section: Collect
 - display: Incident type
   name: incidentType
   defaultvalue: Recorded Future Playbook Alert
   type: 13
   required: false
+  section: Collect
 script:
   script: '-'
   type: python
   subtype: python3
-  dockerimage: demisto/python3:3.11.10.111039
+  dockerimage: demisto/python3:3.12.8.1983910
   commands:
   - name: recordedfuture-playbook-alerts-details
     description: Get Playbook alert details by id.

Packs/RecordedFuture/Integrations/RecordedFuturePlaybookAlerts/RecordedFuturePlaybookAlerts_test.py

@@ -970,7 +970,7 @@ def test_get_client_no_api_token(self, mocker):
 
         mock_params = {
             "server_url": "https://api.recordedfuture.com/gw/xsoar/",
-            "unsecure": False,
+            "insecure": False,
             "token": {"password": None},
         }
         mocker.patch.object(demisto, "params", return_value=mock_params)
@@ -1013,12 +1013,12 @@ def test_get_client_with_proxy(mocker):
 
     server_url = "https://api.recordedfuture.com/gw/xsoar/"
 
-    unsecure = False
-    verify_ssl = not unsecure
+    insecure = False
+    verify_ssl = not insecure
 
     mock_params = {
         "server_url": server_url,
-        "unsecure": unsecure,
+        "insecure": insecure,
         "token": {"password": "example"},
         "proxy": True,
     }
@@ -1046,12 +1046,12 @@ def test_get_client_without_proxy(mocker):
 
     server_url = "https://api.recordedfuture.com/gw/xsoar/"
 
-    unsecure = False
-    verify_ssl = not unsecure
+    insecure = False
+    verify_ssl = not insecure
 
     mock_params = {
         "server_url": server_url,
-        "unsecure": unsecure,
+        "insecure": insecure,
         "token": {"password": "example"},
         "proxy": False,
     }

Packs/RecordedFuture/ReleaseNotes/1_8_3.md

@@ -0,0 +1,6 @@
+#### Integrations
+
+##### Recorded Future - Playbook Alerts
+- Fixed an issue related to "Trust any certificate (not secure)" setting.
+- Updated the Docker image to: *demisto/python3:3.12.8.1983910*.
+- Add sections to settings.

Packs/RecordedFuture/pack_metadata.json

@@ -2,7 +2,7 @@
     "name": "Recorded Future Intelligence",
     "description": "Recorded Future App, this pack is previously known as 'RecordedFuture v2'",
     "support": "partner",
-    "currentVersion": "1.8.2",
+    "currentVersion": "1.8.3",
     "author": "Recorded Future",
     "url": "https://www.recordedfuture.com/support/demisto-integration/",
     "email": "[email protected]",