[UI][Common] Wrap torrent comment and tracker status URLs in HTML (clickable) #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkarry
force-pushed
the
parse-links-to-html
branch
4 times, most recently
from
4f1f7e8 to
466a4da
Compare
cas--
requested changes
Aug 26, 2024
zakkarry
force-pushed
the
parse-links-to-html
branch
6 times, most recently
from
4120ebb to
d3af3b6
Compare
zakkarry
force-pushed
the
parse-links-to-html
branch
2 times, most recently
from
25a61a5 to
5c85405
Compare
|
rebased. |
zakkarry
force-pushed
the
parse-links-to-html
branch
from
5c85405 to
7d40560
Compare
cas--
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to common.py that uses a
re.subfunction to wrap supported URLs (taken from the is_url function) with HTML.With this function, the torrent comments in
details_taband tracker status intrackers_tabwill now display these URLs as clickable hyperlinks.This was previously only supported where the comment itself was only a URL. It will now support links within the comment. Also for tracker errors that give a link, in the case of removal and replacement for a new torrent on a tracker, the link reported in the status is now clickable too.