Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR copies files to share, to give the original file name to other apps.
closes #2524
before
this is the baseline:
after
the filename is
test.pdf
- the extension is hidden by iOS, and shown as the type:other tests
i tested also to set metadata instead of copying, this was fine in the "share preview", however, the final app again gets the wrong filename, see details below.
i tried that using all of
activityViewControllerPlaceholderItem
,LPLinkMetadata.originalURL
,LPLinkMetadata.title
,QLPreviewItem.title
- none of them worked for me.the gallery, however, still contains the scrambled names, copying them would require to copy all images on each swipe, that seems over the too. also, when sharing images, the name is barely anywhere displayed on the destination apps - and even the unscrambled name often looks scrambles.
still, user can share from delta chat and not from gallery to get the correct names. if ppl complain at scale, we can iterate :)