Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve filenames on sharing #2605

Merged
merged 2 commits into from
Feb 12, 2025
Merged

preserve filenames on sharing #2605

merged 2 commits into from
Feb 12, 2025

Conversation

r10s
Copy link
Member

@r10s r10s commented Feb 12, 2025

this PR copies files to share, to give the original file name to other apps.

closes #2524

before

this is the baseline:

after

the filename is test.pdf - the extension is hidden by iOS, and shown as the type:

other tests

i tested also to set metadata instead of copying, this was fine in the "share preview", however, the final app again gets the wrong filename, see details below.

i tried that using all of activityViewControllerPlaceholderItem, LPLinkMetadata.originalURL, LPLinkMetadata.title, QLPreviewItem.title - none of them worked for me.

the gallery, however, still contains the scrambled names, copying them would require to copy all images on each swipe, that seems over the too. also, when sharing images, the name is barely anywhere displayed on the destination apps - and even the unscrambled name often looks scrambles.

still, user can share from delta chat and not from gallery to get the correct names. if ppl complain at scale, we can iterate :)

@r10s r10s marked this pull request as ready for review February 12, 2025 17:19
@r10s r10s merged commit 57b1e79 into main Feb 12, 2025
2 checks passed
@r10s r10s deleted the r10s/share-file-names branch February 12, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to file deduplication
2 participants