use 'bookmark' symbol for 'saved messages', tweak forwarding #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"bookmark" is is harder to mix with emoji, makes clear, things are local. it also seems more often used for 'save' in comparable apps, and it fits to our 'saved messages' icon
r10s
force-pushed
the
r10s/bookmark-symbol
branch
from
5a7c326 to
bdcdfd0
Compare
r10s
changed the title
r10s
force-pushed
the
r10s/bookmark-symbol
branch
from
22ef0bc to
b3ddc7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after some discussion with @adbenitez , the bookmark symbol is better for 'save' than a star:
moreover, this PR tweaks forwarding, so that forwarding to 'saved messages', if possible, saves the message instead if of forwarding it
the lock icon could also be sharper, but that is another PR then :)