preserve filenames on sharing

deltachat · Feb 12, 2025 · 8294843 · 8294843
1 parent 5b36141
commit 8294843
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/deltachat-ios/Helper/FileHelper.swift b/deltachat-ios/Helper/FileHelper.swift
@@ -87,4 +87,17 @@ public class FileHelper {
             print("err: \(error.localizedDescription)")
         }
     }
+
+    static func copyIfPossible(src: URL, dest: URL) -> URL {
+        do {
+            if FileManager.default.fileExists(atPath: dest.path) {
+                try FileManager.default.removeItem(at: dest)
+            }
+            try FileManager.default.copyItem(at: src, to: dest)
+            return dest
+        } catch {
+            logger.error("cannot copy \(src) to \(dest)")
+            return src
+        }
+    }
 }
diff --git a/deltachat-ios/Helper/Utils.swift b/deltachat-ios/Helper/Utils.swift
@@ -94,17 +94,26 @@ struct Utils {
     }
 
     public static func share(message: DcMsg, parentViewController: UIViewController, sourceView: UIView? = nil, sourceItem: UIBarButtonItem? = nil) {
-        guard let fileURL = message.fileURL else { return }
+        guard let scrambledURL = message.fileURL else { return }
+
+        let shareURL: URL
+        if let filename = message.filename {
+            let cleanURL = FileManager.default.temporaryDirectory.appendingPathComponent(filename)
+            shareURL = FileHelper.copyIfPossible(src: scrambledURL, dest: cleanURL)
+        } else {
+            shareURL = scrambledURL
+        }
+
         let objectsToShare: [Any]
         if message.type == DC_MSG_WEBXDC {
             let dict = message.getWebxdcInfoDict()
             let previewImage = message.getWebxdcPreviewImage()
-            let previewText = dict["name"] as? String ?? fileURL.lastPathComponent
+            let previewText = dict["name"] as? String ?? shareURL.lastPathComponent
             objectsToShare = [WebxdcItemSource(title: previewText,
                                                previewImage: previewImage,
-                                               url: fileURL)]
+                                               url: shareURL)]
         } else {
-            objectsToShare = [fileURL]
+            objectsToShare = [shareURL]
         }
 
         let activityVC = UIActivityViewController(activityItems: objectsToShare, applicationActivities: nil)