no saving of info-messages

saving info-messages would result in having them displayed out of context, which is confusing. one can think over display them differently, but that seems not worth the effort. not allowing to save info-messages is also what whatsapp is doing.
deltachat · Jan 31, 2025 · 2f3e039 · 2f3e039
1 parent b8bb25d
commit 2f3e039
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/deltachat-ios/Chat/ChatViewController.swift b/deltachat-ios/Chat/ChatViewController.swift
@@ -1934,14 +1934,16 @@ extension ChatViewController {
                     UIAction.menuAction(localizationKey: "forward", image: image, indexPath: indexPath, action: forward)
                 )
 
-                if dcChat.isSelfTalk || message.savedMessageId != 0 {
-                    children.append(
-                        UIAction.menuAction(localizationKey: "unsave", systemImageName: "star.slash", indexPath: indexPath, action: toggleSave)
-                    )
-                } else {
-                    children.append(
-                        UIAction.menuAction(localizationKey: "save_desktop", systemImageName: "star", indexPath: indexPath, action: toggleSave)
-                    )
+                if !message.isInfo { // info-messages out of context results in confusion, see https://github.com/deltachat/deltachat-ios/issues/2567
+                    if dcChat.isSelfTalk || message.savedMessageId != 0 {
+                        children.append(
+                            UIAction.menuAction(localizationKey: "unsave", systemImageName: "star.slash", indexPath: indexPath, action: toggleSave)
+                        )
+                    } else {
+                        children.append(
+                            UIAction.menuAction(localizationKey: "save_desktop", systemImageName: "star", indexPath: indexPath, action: toggleSave)
+                        )
+                    }
                 }
 
                 if let link = isLinkTapped(indexPath: indexPath, point: point) {