Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved messages #4674

Merged
merged 14 commits into from
Mar 1, 2025
Merged

Saved messages #4674

merged 14 commits into from
Mar 1, 2025

Conversation

nicodh
Copy link
Member

@nicodh nicodh commented Feb 18, 2025 •
edited
Loading

Relates to #4596

  • enable to save (or unsave) message from context menu of messages
  • show sender & avatar in self chat for saved messages
  • show bookmark icon for saved messages in self chat
  • show bookmark icon for saved messages in any chat
  • show button to jump to original message

New item in context menu:

image

New bookmark icons

image

New jump to original message button

image

@nicodh nicodh marked this pull request as draft February 18, 2025 09:28
@Simon-Laux Simon-Laux added enhancement New feature or request new-core involves or requires an core update new DC feature New features in core that need adaptions in desktop and removed enhancement New feature or request labels Feb 20, 2025
@nicodh nicodh removed the new-core involves or requires an core update label Feb 27, 2025
@nicodh nicodh marked this pull request as ready for review February 27, 2025 21:24
@nicodh nicodh requested review from Simon-Laux and WofWca February 27, 2025 21:25
@Simon-Laux Simon-Laux requested a review from r10s February 27, 2025 22:30
r10s
r10s reviewed Feb 28, 2025
View reviewed changes
packages/frontend/src/components/ShortcutMenu/index.tsx Outdated
Comment on lines 57 to 59
aria-label={tx('jump_to_original_message')}
onClick={onClick}
title={tx('jump_to_original_message')}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems I was too fast :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change it again once you added the new string...

@ralphtheninja
Copy link
Member

Should one be able to save messages, within saved messages?

image

nicodh
nicodh commented Feb 28, 2025
View reviewed changes
packages/frontend/src/components/ShortcutMenu/index.tsx Outdated
Comment on lines 57 to 59
aria-label={tx('jump_to_original_message')}
onClick={onClick}
title={tx('jump_to_original_message')}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems I was too fast :-)

@nicodh
Copy link
Member Author

nicodh commented Feb 28, 2025

Should one be able to save messages, within saved messages?

I think @r10s once said they allow it in Android?

ralphtheninja
ralphtheninja approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by testing. Works well!

@r10s
Copy link
Member

r10s commented Feb 28, 2025

Should one be able to save messages, within saved messages?

no, this should not be possible. it is also not possible on android, that does not have a dedicated "save" button yet (but that is requested and coming). on iOS we hide the "save" and "unsave" button within saved messages ("unsave" equals "delete" there).

so, we should just hide save/unsave in "saved messages"

@nicodh
Copy link
Member Author

nicodh commented Feb 28, 2025

so, we should just hide save/unsave in "saved messages"

Done with commit 146b81a

@nicodh nicodh merged commit 74bfa99 into main Mar 1, 2025
12 checks passed
@nicodh nicodh deleted the saved-messages branch March 1, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s left review comments

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@Simon-Laux Simon-Laux Simon-Laux approved these changes

@WofWca WofWca Awaiting requested review from WofWca

Assignees
No one assigned
Labels
new DC feature New features in core that need adaptions in desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicodh @ralphtheninja @r10s @Simon-Laux