Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tauri: build failing (base64 dependency) #4626

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix: tauri: build failing (base64 dependency) #4626

merged 1 commit into from
Feb 11, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Feb 11, 2025 •
edited
Loading

Apparently it started failing after #4533.

#skip-changelog

@WofWca WofWca marked this pull request as ready for review February 11, 2025 14:50
@WofWca WofWca requested review from Simon-Laux and Septias February 11, 2025 14:51
@WofWca
Copy link
Collaborator Author

WofWca commented Feb 11, 2025

The E2E test failed at group creation, as usual.

@nicodh nicodh self-requested a review February 11, 2025 15:23
nicodh
nicodh approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by result: fixes the failings checks

@WofWca WofWca merged commit 509d886 into main Feb 11, 2025
19 checks passed
@WofWca WofWca deleted the wofwca/fix-tauri-build branch February 11, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicodh nicodh nicodh approved these changes

@Simon-Laux Simon-Laux Awaiting requested review from Simon-Laux

@Septias Septias Awaiting requested review from Septias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WofWca @nicodh