refine QR reset wording #3568
Merged
refine QR reset wording #3568
+36
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbenitez
approved these changes
Jan 30, 2025
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR streamlines resetting QR codes, mitigating lots of confusion we encountered on testing.
use "reset", as known from other messengers - and which is also more accurate as a new QR code will be created immediately as needed
simpler "activate" wording, tbh, i am not sure if that is even a thing that will ppl do
incorporate "invite link" wording, at least partly
to make adaption easier, it does not split strings for so (eg. use different strings for scanning and button), so other OS will benefit without doing additional things.
moreover, the PR adapts the layout, uses colors and uses "reset" only as primary button when selected via menu entry. this is how it looks like.
the weird primary button was also often cause of confusion.