Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
they are not actionable currently
  • Loading branch information
Hocuri committed Jan 19, 2025
1 parent d440590 commit 73a9f89
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ public int getHeight() {
return height;
}

// TODO the following function can prob. be deleted now. Adb may be able to tell me some context why it was introduced.
public String getRealPath(Context context) {
try {
// get file in the blobdir as `<blobdir>/<name>[-<uniqueNumber>].<ext>`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,13 @@ private static String checkMime(String path, String mimeType) {
return mimeType;
}

// TODO the following function can prob. be simplified and unified with the next fn now.
/**
* Return the path of a not-yet-existing file in the blobdir with roughly the given filename
* and the given extension.
* In many cases, since we're using setFileAndDeduplicate now, this wouldn't be necessary anymore
* and we could just create a file with a random filename,
* but there are a few usages that still need the current behavior (like `openMaps()`).
*/
public static String getBlobdirFile(DcContext dcContext, String filename, String ext) {
filename = FileUtils.sanitizeFilename(filename);
ext = FileUtils.sanitizeFilename(ext);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ public void onReceivedDuration(int millis) {
return null;
}

// TODO we should be able to revert the changes here
private @NonNull Slide getManuallyCalculatedSlideInfo(Uri uri, int width, int height, @Nullable DcMsg msg) throws IOException {
long start = System.currentTimeMillis();
Long mediaSize = null;
Expand Down

0 comments on commit 73a9f89

Please sign in to comment.