Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unimplemented error; update workflow #10

Open
wants to merge 1 commit into
base: gma/cpu_support
Choose a base branch
from

Conversation

Yejing-Lai
Copy link

skip logic:

  1. Builder name does not exist or is not implemented, then skip.
  2. Use “skipif(CPU)” to skip some test cases on the CPU device.

@delock
Copy link
Owner

delock commented Apr 23, 2023

Overall comments: we should avoid compare backend name against certain accelerator name. Instead, check for certain features that are required by the case. These tests that check for not implemented is a good example. Its reasonable to skip a UT if feature are not implemented, but not reasonable to skip just because it cannot pass for certain accelerator.

@Yejing-Lai Yejing-Lai force-pushed the gma/cpu_support branch 3 times, most recently from c86bb2b to e759de6 Compare April 27, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants