Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go version bump-up #147

Merged
merged 2 commits into from
Feb 23, 2024
Merged

go version bump-up #147

merged 2 commits into from
Feb 23, 2024

Conversation

nitesh3108
Copy link
Contributor

Updating go version to latest available i.e. => 1.22

Signed-off-by: nitesh3108 <[email protected]>
@csmbot
Copy link
Collaborator

csmbot commented Feb 21, 2024

Can one of the admins verify this patch?

Signed-off-by: nitesh3108 <[email protected]>
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip e2e test

- name: Set up Go lastest
- name: Set up Go 1.22+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the opposite of what I saw in the other PRs where latest was used.

@donatwork
Copy link
Contributor

e2e pass

@chimanjain chimanjain merged commit 91595d2 into main Feb 23, 2024
7 of 8 checks passed
@chimanjain chimanjain deleted the go-version-bumpup-1.22 branch February 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants