Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Increase code coverage #81

wants to merge 2 commits into from
+13,404 −1,748

Conversation

AkshaySainiDell
Copy link

@AkshaySainiDell AkshaySainiDell commented Jan 10, 2025 •
edited by rishabhatdell
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

This PR increases the UT coverage

@KshitijaKakde KshitijaKakde force-pushed the chore-code-coverage branch 2 times, most recently from a8fa4c6 to 8506521 Compare January 27, 2025 04:38
@adarsh-dell adarsh-dell marked this pull request as ready for review February 11, 2025 11:34
@adarsh-dell adarsh-dell changed the title [WIP] Increase code coverage Increase code coverage Feb 11, 2025
@chimanjain
Copy link
Collaborator

Can you run e2e with the changes as we are modifying go files also to make sure we are not introducing any breaking changes.

@AkshaySainiDell
Copy link
Author

@chimanjain, the changes to the Go files primarily involve converting unexported variables to exported ones, which was necessary for writing the unit tests. No changes have been made to the functionality.

HarishH-DELL
HarishH-DELL approved these changes Feb 12, 2025 •
edited
Loading
View reviewed changes
@chimanjain
Copy link
Collaborator

Thanks @AkshaySainiDell for clarifying. LGTM

@HarishH-DELL HarishH-DELL self-requested a review February 12, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@chimanjain chimanjain chimanjain approved these changes

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@anathoodell anathoodell anathoodell approved these changes

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AkshaySainiDell @chimanjain @donatwork @bpjain2004 @anathoodell @HarishH-DELL @suryagupta4