Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-1737]: Check if CSM is Authorization Proxy Server by checking module name #893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atye
Copy link
Contributor

@atye atye commented Feb 6, 2025

Description

When calculating state, the CSM name is checked to determine if the CSM is the Authorization Proxy Server or not. If the CSM name is not the default name, authorization, reconciling fails. Determining if the CSM is the Authorization Proxy Server or not should be be hardened by checking if a module name in the spec is authorization-proxy-server.

Changes:

  • Check if the CSM is the Authorization Proxy Server by checking the module name in the spec
  • Add missing deployment check for authorization-controller when checking Authorization status

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1737

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Updated and new unit tests. Installed Authorization using default and non-default names.

# kubectl -n csm-authorization get csm
NAME                CREATIONTIME   CSIDRIVERTYPE   CONFIGVERSION   STATE
csm-authorization   56s                                            Succeeded


# kubectl -n csm-authorization get csm
NAME            CREATIONTIME   CSIDRIVERTYPE   CONFIGVERSION   STATE
authorization   65s                                            Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant