Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth v2 e2e tests using PowerMax mount credentials #892

Draft
wants to merge 4 commits into
base: usr/spark/mount-credentials
Choose a base branch
from

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Feb 6, 2025

Description

Add E2E tests that installs the Powermax driver using mount credentials and enables Authorization v2.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1614

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration


@@ -6,7 +6,7 @@ env:
value: /etc/config/configmap
- name: X_CSI_REVPROXY_CONFIG_FILE_NAME
value: config.yaml
- name: X_CSI_REVRPOXY_IN_CLUSTER
- name: X_CSI_REVPROXY_IN_CLUSTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I don't think we should update the environment variable in older releases because that change wouldn't be in the code parsing, right?

backupEndpoint: "https://REPLACE_AUTH_ENDPOINT"
managementServers:
- endpoint: "https://REPLACE_AUTH_ENDPOINT"
username: REPLACE_USERNAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Don't replace username and password (leave as -) so that there isn't any confusion with what needs to be added in the secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants