Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check for claimRef to avoid segmentation violation error #31

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

HarishH-DELL
Copy link
Contributor

@HarishH-DELL HarishH-DELL commented Nov 27, 2023

Description

  • Added a nil check to skip processing pvs without ClaimRef. This will prevent karavi-metrics-powermax from crashing when there are unbound pv s in clusters
  • Enhanced unit tests to cover the same

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1019

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Tested the scenario using unit tests and it looks good
image

@csmbot
Copy link
Collaborator

csmbot commented Nov 27, 2023

Can one of the admins verify this patch?

@gallacher
Copy link
Collaborator

run e2e test

@donatwork
Copy link
Contributor

skip e2e test

@donatwork
Copy link
Contributor

e2e pass

@HarishH-DELL HarishH-DELL merged commit 5014e59 into main Nov 27, 2023
7 checks passed
@anandrajak1 anandrajak1 deleted the bug-1019-nil-check-to-avoid-seg-violation-error branch October 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants