Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Powermax and Unity Prerequisite #1462

Merged
merged 5 commits into from
Mar 4, 2025
Merged

Update Powermax and Unity Prerequisite #1462

merged 5 commits into from
Mar 4, 2025

Conversation

sidharth30060
Copy link
Collaborator

Description

Add MachineConfig in Unity Prerequisite (OpenShift) and simplified PowerMax Prerequisite in context of Openshift

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1761

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f560ec5. ± Comparison against base commit ceaf77b.

♻️ This comment has been updated with latest results.

@sidharth30060 sidharth30060 marked this pull request as ready for review March 4, 2025 08:00
prablr79
prablr79 previously approved these changes Mar 4, 2025
View reviewed changes
rajkumar-palani
rajkumar-palani previously requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sidharth30060 - can you please add the local preview screenshots which you have tested?

@sidharth30060
Copy link
Collaborator Author

Hi @rajkumar-palani , Local Preview Screenshot - Bug_fix.docx

@anandrajak1 anandrajak1 dismissed rajkumar-palani’s stale review March 4, 2025 12:37

Uploaded the document

anandrajak1
anandrajak1 previously approved these changes Mar 4, 2025
View reviewed changes
@anandrajak1
Copy link
Collaborator

@rajkumar-palani - Please review the doc attached.

@anandrajak1 anandrajak1 dismissed stale reviews from prablr79 and themself via 9b7cd66 March 4, 2025 21:25
mjsdell
mjsdell approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sharmilarama
sharmilarama approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandrajak1 anandrajak1 merged commit 4db7cbc into main Mar 4, 2025
8 checks passed
@anandrajak1 anandrajak1 deleted the doc_bug_fix branch March 4, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsdell mjsdell mjsdell approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@prablr79 prablr79 prablr79 left review comments

@rajkumar-palani rajkumar-palani rajkumar-palani left review comments

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sidharth30060 @anandrajak1 @prablr79 @rajkumar-palani @mjsdell @sharmilarama