Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSM Operator Installation - Added CR fields for PowerMax and PowerFlex #1458

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

CSM Operator Installation - Added CR fields for PowerMax and PowerFlex #1458

wants to merge 9 commits into from
+25 −19

Conversation

ChristianAtDell
Copy link
Contributor

Description

This PR adds documentation to support the changes made in dell/csm-operator#905 .

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1762

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

image

image

@ChristianAtDell ChristianAtDell marked this pull request as ready for review February 27, 2025 17:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   4s ⏱️ -1s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c49ce68. ± Comparison against base commit 78c299a.

♻️ This comment has been updated with latest results.

alikdell
alikdell previously approved these changes Feb 27, 2025
View reviewed changes
@ChristianAtDell ChristianAtDell changed the title added fields to appropriate files CSM Operator Installation - Added CR fields for PowerMax and PowerFlex Feb 27, 2025
rsedlock1958
rsedlock1958 reviewed Feb 27, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No edits required

santhoshatdell
santhoshatdell previously approved these changes Feb 28, 2025
View reviewed changes
AronAtDell
AronAtDell reviewed Feb 28, 2025
View reviewed changes
content/docs/getting-started/installation/kubernetes/powermax/csmoperator/_index.md
@@ -160,6 +160,7 @@ Example:
| X_CSI_VSPHERE_PORTGROUP | Existing portGroup that driver will use for vSphere | Yes | "" |
| X_CSI_VSPHERE_HOSTNAME | Existing host(initiator group)/host group(cascaded initiator group) that driver will use for vSphere | Yes | "" |
| X_CSI_VCenter_HOST | URL/endpoint of the vCenter where all the ESX are present | Yes | "" |
| X_CSI_POWERMAX_DEBUG | Enable/Disable gopowermax library-level debugging. | No | false |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have this also added for other binding layers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this comment with Aron:

gopowermax is the one being added with this PR, so we should be covered.

gopowerscale has:
https://github.com/dell/gopowerscale/blob/ef35bfd90f23593d67077d191328562ec17fc696/api/api.go#L58
but that isn't supported in operator at present.

goscaleio has the http flags, but like gopowerscale, they aren't currently supported in operator.

gopowerstore has:
https://github.com/dell/gopowerstore/blob/171b9c405d0d17e5cdaa2734c80f1637a4c01b5c/api/api.go#L138
and that is supported in operator: https://github.com/dell/csm-operator/blob/04fd860891c3f1ec640d24fbeaa273c18963aa95[…]/operatorconfig/driverconfig/powerstore/v2.13.0/controller.yaml

We don't currently expose that value in our Operator sample, nor do we call it out in csm-docs, but it is possible to add it like I did for the two flags already mentioned in this docs PR. Fairly trivial change in both repos, just add it to the docs tables and add a value to the samples in operator.

...

Per feedback, I am converting this PR to draft and working with my team to increase the scope of this defect and add granular control of library debug flags to other libraries.

@ChristianAtDell ChristianAtDell marked this pull request as draft February 28, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atye atye atye left review comments

@alexemc alexemc alexemc left review comments

@gallacher gallacher gallacher left review comments

@AronAtDell AronAtDell AronAtDell left review comments

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@alikdell alikdell alikdell left review comments

@santhoshatdell santhoshatdell santhoshatdell left review comments

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ChristianAtDell @atye @alexemc @gallacher @AronAtDell @alikdell @sharmilarama @rsedlock1958 @santhoshatdell