Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OCP 4.18 support #1444

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Remove OCP 4.18 support #1444

merged 3 commits into from
Feb 4, 2025

Conversation

chimanjain
Copy link
Contributor

Description

Remove OCP 4.18 support.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1734

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@chimanjain chimanjain marked this pull request as ready for review February 4, 2025 08:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a64da0a. ± Comparison against base commit eeb989f.

♻️ This comment has been updated with latest results.

HarishH-DELL
HarishH-DELL approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajkumar-palani
rajkumar-palani approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chimanjain
Copy link
Contributor Author

Because the new GitHub action for spell check is introduced, we are seeing multiple errors. I will be fixing them in this PR.

@chimanjain chimanjain merged commit 0e243ed into main Feb 4, 2025
8 checks passed
@chimanjain chimanjain deleted the remove-ocp-4.18 branch February 4, 2025 12:26
chimanjain added a commit that referenced this pull request Feb 4, 2025
@chimanjain
Remove OCP 4.18 support (#1444)
f0b6e79 
* remove ocp 4.18 support

* fix spell check errors
sharmilarama pushed a commit that referenced this pull request Feb 6, 2025
@chimanjain
Remove OCP 4.18 support for CSM 1.13 (#1446)
684b575 
* Remove OCP 4.18 support (#1444)

* remove ocp 4.18 support

* fix spell check errors

* fix spell check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chimanjain @rajkumar-palani @bpjain2004 @HarishH-DELL