Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified protocol use in PowerStore #1436

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Clarified protocol use in PowerStore #1436

merged 3 commits into from
Jan 31, 2025

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Jan 29, 2025 •
edited
Loading

Description

Clarified the protocol to be 'scsi' for block-based protocol and 'nfs' for file-based protocol.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1729

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cfec84a. ± Comparison against base commit 5144383.

♻️ This comment has been updated with latest results.

@jooseppi-luna
Copy link
Contributor

Do we want to change v1/v2/v3? I thought those were kept around for historical purposes

@lukeatdell
Copy link
Contributor

lukeatdell commented Jan 30, 2025 •
edited
Loading

Do we want to change v1/v2/v3? I thought those were kept around for historical purposes

@jooseppi-luna
It makes sense to edit the historical docs if this applies to those previous versions of the driver.
In this case, it appears it would apply.

jooseppi-luna
jooseppi-luna approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoppea2 hoppea2 merged commit 7dc202e into main Jan 31, 2025
7 checks passed
@santhoshatdell santhoshatdell deleted the clarify-scsi branch January 31, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoppea2 hoppea2 hoppea2 approved these changes

@lukeatdell lukeatdell lukeatdell approved these changes

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santhoshatdell @jooseppi-luna @lukeatdell @hoppea2 @gallacher