Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CERT-CSI Version Fix #1428

Closed
wants to merge 2 commits into from
Closed

CERT-CSI Version Fix #1428

wants to merge 2 commits into from

Conversation

sidharth30060
Copy link
Collaborator

@sidharth30060 sidharth30060 commented Jan 22, 2025 •
edited
Loading

Description

Updating Cert-CSI Version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1710

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Test Results

77 tests   77 ✅  3s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit e1d1fb0.

♻️ This comment has been updated with latest results.

@francis-nijay francis-nijay marked this pull request as ready for review January 22, 2025 18:24
rsedlock1958
rsedlock1958 reviewed Jan 22, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. NO edits required.

prablr79
prablr79 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Doc changes only. CSM 1.13 Release

rajkumar-palani
rajkumar-palani approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sharmilarama
sharmilarama requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be merged from the changes in main branch. Dev branch changes should not be merged directly into release branches.

@sidharth30060
Copy link
Collaborator Author

sidharth30060 commented Jan 29, 2025 •
edited
Loading

This PR needs to be merged from the changes in main branch. Dev branch changes should not be merged directly into release branches.

@sharmilarama The PR for the main branch has been merged - #1427

@sidharth30060 sidharth30060 deleted the cert-csi_version-fix_2 branch February 4, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@sharmilarama sharmilarama sharmilarama requested changes

@prablr79 prablr79 prablr79 approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sidharth30060 @prablr79 @rajkumar-palani @sharmilarama @rsedlock1958