Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.22 #1301

Merged
merged 18 commits into from
Oct 30, 2024
Merged

Update go version to 1.22 #1301

merged 18 commits into from
Oct 30, 2024

Conversation

csm-release[bot]
Copy link
Contributor

@csm-release csm-release bot commented Oct 21, 2024 •
edited by shaynafinocchiaro
Loading

Go version updated to 1.22
Auto-generated by common-github-actions

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 106f96e. ± Comparison against base commit 3e02001.

♻️ This comment has been updated with latest results.

rajkumar-palani
rajkumar-palani previously requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this change in local preview using go 1.23?

@shaynafinocchiaro
Copy link
Contributor

Have we tested this change in local preview using go 1.23?

Looking into this, currently Hugo will not spin up a server using this go version.

@shaynafinocchiaro shaynafinocchiaro changed the title Update go version to 1.23 Update go version to 1.22 Oct 24, 2024
@shaynafinocchiaro
Copy link
Contributor

Have we tested this change in local preview using go 1.23?

@rajkumar-palani Using the latest version of Hugo extended, we can successfully move to go 1.22. I was able to run a server locally with no issues.

@shaynafinocchiaro shaynafinocchiaro dismissed rajkumar-palani’s stale review October 30, 2024 12:27

Tested change on go 1.22

prablr79
prablr79 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaynafinocchiaro shaynafinocchiaro merged commit f876302 into main Oct 30, 2024
7 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the go-1.23 branch October 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@prablr79 prablr79 prablr79 approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shaynafinocchiaro @donatwork @hoppea2 @prablr79 @rajkumar-palani