Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation wizard template #1282

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

falfaroc
Copy link
Contributor

Description

Update the templates for the installation wizard to match the helm-chart updates.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1281

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Oct 11, 2024

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ -1s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e53b2a1. ± Comparison against base commit c24474d.

♻️ This comment has been updated with latest results.

niranjan-n1
niranjan-n1 previously approved these changes Oct 14, 2024
@niranjan-n1 niranjan-n1 dismissed their stale review October 14, 2024 06:35

The PR is still in Draft

@falfaroc falfaroc marked this pull request as ready for review October 15, 2024 13:15
@falfaroc falfaroc requested a review from niranjan-n1 October 15, 2024 13:15
@tdawe
Copy link
Contributor

tdawe commented Oct 15, 2024

Any other changes required for the Install Wizard or does this template change cover everything? If you use the Install Wizard and provide a different repository than "dellemc", does it properly update the values.yaml output file?

@falfaroc
Copy link
Contributor Author

falfaroc commented Oct 15, 2024

Any other changes required for the Install Wizard or does this template change cover everything? If you use the Install Wizard and provide a different repository than "dellemc", does it properly update the values.yaml output file?

Not to my knowledge. I thought that it would actually download the template for somewhere but they appear to be static and the installation wizard only use the templates in the folder for each version.

@falfaroc falfaroc merged commit 3204cc4 into main Oct 15, 2024
7 checks passed
@falfaroc falfaroc deleted the installation-wizard-template-update branch October 15, 2024 15:53
coulof pushed a commit that referenced this pull request Oct 21, 2024
@sharmilarama sharmilarama mentioned this pull request Oct 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants