Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-93 - Add support for labelling on all resources #130

Merged
merged 14 commits into from
Sep 13, 2024

set labels for dlq subs too

69176d9
Select commit
Loading
Failed to load commit list.
Merged

PUB-93 - Add support for labelling on all resources #130

set labels for dlq subs too
69176d9
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Sep 13, 2024 in 0s

4 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 24
- Added 4
           

Coverage increased per file
===========================
+ src/client/googlePubSub/index.ts  7.894
+ src/client/googlePubSub/subscriptions.ts  2.111
+ src/topic/index.ts  0.833
+ src/subscriber/subscriberV2.ts  0.181
+ src/service/pubsub.ts  0.266
         

Coverage decreased per file
===========================
- src/service/logger.ts  -14.0
         

Complexity increasing per file
==============================
- src/utils.ts  7
- src/client/googlePubSub/deadLetter.ts  7
- src/client/googlePubSub/index.ts  1
- src/service/logger.ts  1
- src/cli/commands/list.ts  1
         

Complexity decreasing per file
==============================
+ src/topic/index.ts  -1
         

Clones added
============
- src/client/googlePubSub/deadLetter.ts  1
- src/client/googlePubSub/index.ts  1
- __tests__/topic.with-custom-credentials.test.ts  1
- __tests__/subscription.with-custom-credentials.test.ts  1
- src/topic/index.ts  1
         

Clones removed
==============
+ __tests__/topic.test.ts  -2
         

See the complete overview on Codacy

Annotations

Check failure on line 1 in src/client/googlePubSub/deadLetter.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/client/googlePubSub/deadLetter.ts#L1

Unable to resolve path to module '@google-cloud/pubsub'.

Check notice on line 105 in src/client/googlePubSub/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/client/googlePubSub/index.ts#L105

Replace `·await·this.handleDeadLetterPolicyConfigurations(⏎······subscriber,⏎····` with `⏎······await·this.handleDeadLetterPolicyConfigurations(subscriber`

Check failure on line 1 in src/topic/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/topic/index.ts#L1

Unable to resolve path to module '@google-cloud/pubsub'.

Check failure on line 1 in src/utils.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/utils.ts#L1

Unable to resolve path to module '@google-cloud/pubsub'.