Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: support modifying tolerations #642

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[stable/node-local-dns]: support modifying tolerations #642

merged 2 commits into from
Dec 17, 2024

Conversation

woehrl01
Copy link
Contributor

@woehrl01 woehrl01 commented Dec 16, 2024 •
edited
Loading

Description

Allow to change "tolerations" of the deamonset

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@woehrl01 woehrl01 requested a review from a team as a code owner December 16, 2024 15:24
@woehrl01 woehrl01 changed the title feat(node-local-dns): support modifying tolerations [stable/mychartnnode-local-dnsame]: support modifying tolerations Dec 16, 2024
@woehrl01 woehrl01 force-pushed the configure-tolerations branch from ee34f59 to aecb9b8 Compare December 16, 2024 15:26
@woehrl01 woehrl01 changed the title [stable/mychartnnode-local-dnsame]: support modifying tolerations [stable/node-local-dns]: support modifying tolerations Dec 16, 2024
max-rocket-internet
max-rocket-internet approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @woehrl01, but you have to regenerate the README

@woehrl01 woehrl01 force-pushed the configure-tolerations branch from aecb9b8 to 90d1c56 Compare December 17, 2024 09:42
@woehrl01
Copy link
Contributor Author

@max-rocket-internet Just pushed the generated readme changes.

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) December 17, 2024 09:49
@max-rocket-internet max-rocket-internet merged commit 374da15 into deliveryhero:master Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woehrl01 @max-rocket-internet