Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/cluster-overprovisioner] add terminationGracePeriodSeconds #635

Merged
merged 2 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/cluster-overprovisioner/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ description: |
This approach is the [current recommended method to achieve overprovisioning](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#how-can-i-configure-overprovisioning-with-cluster-autoscaler).
name: cluster-overprovisioner
home: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler
version: 0.7.11
version: 0.7.12
maintainers:
- name: max-rocket-internet
email: [email protected]
Expand Down
5 changes: 3 additions & 2 deletions stable/cluster-overprovisioner/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# cluster-overprovisioner

![Version: 0.7.11](https://img.shields.io/badge/Version-0.7.11-informational?style=flat-square) ![AppVersion: 3.9](https://img.shields.io/badge/AppVersion-3.9-informational?style=flat-square)
![Version: 0.7.12](https://img.shields.io/badge/Version-0.7.12-informational?style=flat-square) ![AppVersion: 3.9](https://img.shields.io/badge/AppVersion-3.9-informational?style=flat-square)

This chart provide a buffer for cluster autoscaling to allow overprovisioning of cluster nodes. This is desired when you have work loads that need to scale up quickly without waiting for the new cluster nodes to be created and join the cluster.

Expand All @@ -21,7 +21,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/cluster-over
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/cluster-overprovisioner --version 0.7.11
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/cluster-overprovisioner --version 0.7.12
```

To install the chart with the release name `my-release`:
Expand Down Expand Up @@ -86,6 +86,7 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/cluster-overprovi
| serviceAccount.automountServiceAccountToken | bool | `true` | Automount API credentials for a Service Account |
| serviceAccount.create | bool | `true` | Determine whether a Service Account should be created or it should reuse an exiting one |
| serviceAccount.name | string | `nil` | The name of the ServiceAccount to use. If not set and create is `true`, a name is generated using the fullname template |
| terminationGracePeriodSeconds | int | `0` | Time for graceful pod termination |

## Maintainers

Expand Down
4 changes: 4 additions & 0 deletions stable/cluster-overprovisioner/templates/deployments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
{{- $chartName := .Chart.Name }}
{{- $containerSecurityContext := .Values.containerSecurityContext }}
{{- $podSecurityContext := .Values.podSecurityContext }}
{{- $terminationGracePeriodSeconds := .Values.terminationGracePeriodSeconds }}
{{- $priorityClassName := .Values.priorityClassOverprovision.name }}
{{- $repository := .Values.image.repository }}
{{- $imageTag := default .Chart.AppVersion .Values.image.tag }}
Expand Down Expand Up @@ -95,6 +96,9 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with $terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ $terminationGracePeriodSeconds }}
{{- end }}
{{- with .topologySpreadConstraints }}
topologySpreadConstraints:
{{- range . }}
Expand Down
3 changes: 3 additions & 0 deletions stable/cluster-overprovisioner/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ priorityClassDefault:
# priorityClassDefault.value -- Priority value of the default priorityClass
value: 0

# terminationGracePeriodSeconds -- Time for graceful pod termination
terminationGracePeriodSeconds: 0

image:
# image.repository -- Image repository
repository: registry.k8s.io/pause
Expand Down
Loading